Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Issue 2897243002: Revert of [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h" 5 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/feature_list.h"
10 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
11 #include "base/time/time.h" 10 #include "base/time/time.h"
12 #include "base/timer/timer.h" 11 #include "base/timer/timer.h"
13 #include "chrome/common/chrome_features.h"
14 #include "chrome/common/page_load_metrics/page_load_metrics_messages.h"
15 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" 12 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
16 #include "chrome/renderer/page_load_metrics/page_timing_sender.h"
17 #include "chrome/renderer/page_load_metrics/renderer_page_track_decider.h" 13 #include "chrome/renderer/page_load_metrics/renderer_page_track_decider.h"
18 #include "chrome/renderer/searchbox/search_bouncer.h" 14 #include "chrome/renderer/searchbox/search_bouncer.h"
19 #include "content/public/common/associated_interface_provider.h"
20 #include "content/public/renderer/render_frame.h" 15 #include "content/public/renderer/render_frame.h"
21 #include "third_party/WebKit/public/web/WebDataSource.h" 16 #include "third_party/WebKit/public/web/WebDataSource.h"
22 #include "third_party/WebKit/public/web/WebDocument.h" 17 #include "third_party/WebKit/public/web/WebDocument.h"
23 #include "third_party/WebKit/public/web/WebLocalFrame.h" 18 #include "third_party/WebKit/public/web/WebLocalFrame.h"
24 #include "third_party/WebKit/public/web/WebPerformance.h" 19 #include "third_party/WebKit/public/web/WebPerformance.h"
25 #include "url/gurl.h" 20 #include "url/gurl.h"
26 21
27 namespace page_load_metrics { 22 namespace page_load_metrics {
28 23
29 namespace { 24 namespace {
30 25
31 base::TimeDelta ClampDelta(double event, double start) { 26 base::TimeDelta ClampDelta(double event, double start) {
32 if (event - start < 0) 27 if (event - start < 0)
33 event = start; 28 event = start;
34 return base::Time::FromDoubleT(event) - base::Time::FromDoubleT(start); 29 return base::Time::FromDoubleT(event) - base::Time::FromDoubleT(start);
35 } 30 }
36 31
37 class LegacyIPCPageTimingSender : public PageTimingSender {
38 public:
39 LegacyIPCPageTimingSender(content::RenderFrame* render_frame,
40 const int routing_id)
41 : render_frame_(render_frame), routing_id_(routing_id) {}
42 ~LegacyIPCPageTimingSender() override {}
43
44 void SendTiming(const mojom::PageLoadTimingPtr& timing,
45 const mojom::PageLoadMetadataPtr& metadata) override {
46 DCHECK(render_frame_);
47 render_frame_->Send(
48 new PageLoadMetricsMsg_TimingUpdated(routing_id_, *timing, *metadata));
49 }
50
51 private:
52 content::RenderFrame* const render_frame_;
53 const int routing_id_;
54 };
55
56 class MojoIPCPageTimingSender : public PageTimingSender {
57 public:
58 explicit MojoIPCPageTimingSender(content::RenderFrame* render_frame) {
59 DCHECK(render_frame);
60 render_frame->GetRemoteAssociatedInterfaces()->GetInterface(
61 &page_load_metrics_);
62 }
63 ~MojoIPCPageTimingSender() override {}
64 void SendTiming(const mojom::PageLoadTimingPtr& timing,
65 const mojom::PageLoadMetadataPtr& metadata) override {
66 DCHECK(page_load_metrics_);
67 page_load_metrics_->UpdateTiming(timing->Clone(), metadata->Clone());
68 }
69
70 private:
71 // Use associated interface to make sure mojo messages are ordered with regard
72 // to legacy IPC messages.
73 mojom::PageLoadMetricsAssociatedPtr page_load_metrics_;
74 };
75
76 } // namespace 32 } // namespace
77 33
78 MetricsRenderFrameObserver::MetricsRenderFrameObserver( 34 MetricsRenderFrameObserver::MetricsRenderFrameObserver(
79 content::RenderFrame* render_frame) 35 content::RenderFrame* render_frame)
80 : content::RenderFrameObserver(render_frame) {} 36 : content::RenderFrameObserver(render_frame) {}
81 37
82 MetricsRenderFrameObserver::~MetricsRenderFrameObserver() {} 38 MetricsRenderFrameObserver::~MetricsRenderFrameObserver() {}
83 39
84 void MetricsRenderFrameObserver::DidChangePerformanceTiming() { 40 void MetricsRenderFrameObserver::DidChangePerformanceTiming() {
85 SendMetrics(); 41 SendMetrics();
(...skipping 22 matching lines...) Expand all
108 64
109 // Make sure to release the sender for a previous navigation, if we have one. 65 // Make sure to release the sender for a previous navigation, if we have one.
110 page_timing_metrics_sender_.reset(); 66 page_timing_metrics_sender_.reset();
111 67
112 // We only create a PageTimingMetricsSender if the page meets the criteria for 68 // We only create a PageTimingMetricsSender if the page meets the criteria for
113 // sending and recording metrics. Once page_timing_metrics_sender_ is 69 // sending and recording metrics. Once page_timing_metrics_sender_ is
114 // non-null, we will send metrics for the current page at some later time, as 70 // non-null, we will send metrics for the current page at some later time, as
115 // those metrics become available. 71 // those metrics become available.
116 if (ShouldSendMetrics()) { 72 if (ShouldSendMetrics()) {
117 page_timing_metrics_sender_ = base::MakeUnique<PageTimingMetricsSender>( 73 page_timing_metrics_sender_ = base::MakeUnique<PageTimingMetricsSender>(
118 CreatePageTimingSender(), CreateTimer(), GetTiming()); 74 this, routing_id(), CreateTimer(), GetTiming());
119 } 75 }
120 } 76 }
121 77
122 void MetricsRenderFrameObserver::SendMetrics() { 78 void MetricsRenderFrameObserver::SendMetrics() {
123 if (!page_timing_metrics_sender_) 79 if (!page_timing_metrics_sender_)
124 return; 80 return;
125 if (HasNoRenderFrame()) 81 if (HasNoRenderFrame())
126 return; 82 return;
127 page_timing_metrics_sender_->Send(GetTiming()); 83 page_timing_metrics_sender_->Send(GetTiming());
128 } 84 }
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 timing->style_sheet_timing->update_style_duration_before_fcp = 160 timing->style_sheet_timing->update_style_duration_before_fcp =
205 base::TimeDelta::FromSecondsD(perf.UpdateStyleDurationBeforeFCP()); 161 base::TimeDelta::FromSecondsD(perf.UpdateStyleDurationBeforeFCP());
206 } 162 }
207 return timing; 163 return timing;
208 } 164 }
209 165
210 std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const { 166 std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const {
211 return base::WrapUnique(new base::OneShotTimer); 167 return base::WrapUnique(new base::OneShotTimer);
212 } 168 }
213 169
214 std::unique_ptr<PageTimingSender>
215 MetricsRenderFrameObserver::CreatePageTimingSender() {
216 if (base::FeatureList::IsEnabled(features::kPageLoadMetricsMojofication)) {
217 return base::WrapUnique<PageTimingSender>(
218 new MojoIPCPageTimingSender(render_frame()));
219 }
220 return base::WrapUnique<PageTimingSender>(
221 new LegacyIPCPageTimingSender(render_frame(), routing_id()));
222 }
223
224 bool MetricsRenderFrameObserver::HasNoRenderFrame() const { 170 bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
225 bool no_frame = !render_frame() || !render_frame()->GetWebFrame(); 171 bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
226 DCHECK(!no_frame); 172 DCHECK(!no_frame);
227 return no_frame; 173 return no_frame;
228 } 174 }
229 175
230 void MetricsRenderFrameObserver::OnDestruct() { 176 void MetricsRenderFrameObserver::OnDestruct() {
231 delete this; 177 delete this;
232 } 178 }
233 179
234 } // namespace page_load_metrics 180 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698