Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.h

Issue 2897243002: Revert of [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
diff --git a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
index 910f4f6d4269d63b205ac2b9afe7b8e4163cce00..3f3d2f50567489ecc21868b273716b118f890a21 100644
--- a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
+++ b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
@@ -15,16 +15,19 @@
class Timer;
} // namespace base
+namespace IPC {
+class Sender;
+} // namespace IPC
+
namespace page_load_metrics {
-
-class PageTimingSender;
// PageTimingMetricsSender is responsible for sending page load timing metrics
// over IPC. PageTimingMetricsSender may coalesce sent IPCs in order to
// minimize IPC contention.
class PageTimingMetricsSender {
public:
- PageTimingMetricsSender(std::unique_ptr<PageTimingSender> sender,
+ PageTimingMetricsSender(IPC::Sender* ipc_sender,
+ int routing_id,
std::unique_ptr<base::Timer> timer,
mojom::PageLoadTimingPtr initial_timing);
~PageTimingMetricsSender();
@@ -39,13 +42,14 @@
void EnsureSendTimer();
void SendNow();
- std::unique_ptr<PageTimingSender> sender_;
+ IPC::Sender* const ipc_sender_;
+ const int routing_id_;
std::unique_ptr<base::Timer> timer_;
mojom::PageLoadTimingPtr last_timing_;
// The the sender keep track of metadata as it comes in, because the sender is
// scoped to a single committed load.
- mojom::PageLoadMetadataPtr metadata_;
+ mojom::PageLoadMetadata metadata_;
bool have_sent_ipc_ = false;

Powered by Google App Engine
This is Rietveld 408576698