Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc

Issue 2897243002: Revert of [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
diff --git a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
index d10374968e46bf5a1187e3f843bc398960f7ff28..e1d242448a98d1f55934e4453edc0528d52fffc3 100644
--- a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
+++ b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
@@ -9,7 +9,8 @@
#include "base/callback.h"
#include "base/time/time.h"
#include "base/timer/timer.h"
-#include "chrome/renderer/page_load_metrics/page_timing_sender.h"
+#include "chrome/common/page_load_metrics/page_load_metrics_messages.h"
+#include "ipc/ipc_sender.h"
namespace page_load_metrics {
@@ -19,13 +20,15 @@
} // namespace
PageTimingMetricsSender::PageTimingMetricsSender(
- std::unique_ptr<PageTimingSender> sender,
+ IPC::Sender* ipc_sender,
+ int routing_id,
std::unique_ptr<base::Timer> timer,
mojom::PageLoadTimingPtr initial_timing)
- : sender_(std::move(sender)),
+ : ipc_sender_(ipc_sender),
+ routing_id_(routing_id),
timer_(std::move(timer)),
last_timing_(std::move(initial_timing)),
- metadata_(mojom::PageLoadMetadata::New()) {
+ metadata_(mojom::PageLoadMetadata()) {
if (!IsEmpty(*last_timing_)) {
EnsureSendTimer();
}
@@ -42,9 +45,9 @@
void PageTimingMetricsSender::DidObserveLoadingBehavior(
blink::WebLoadingBehaviorFlag behavior) {
- if (behavior & metadata_->behavior_flags)
+ if (behavior & metadata_.behavior_flags)
return;
- metadata_->behavior_flags |= behavior;
+ metadata_.behavior_flags |= behavior;
EnsureSendTimer();
}
@@ -78,7 +81,8 @@
void PageTimingMetricsSender::SendNow() {
have_sent_ipc_ = true;
- sender_->SendTiming(last_timing_, metadata_);
+ ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated(
+ routing_id_, *last_timing_, metadata_));
}
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698