Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2897243002: Revert of [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "chrome/common/page_load_metrics/page_load_timing.h" 11 #include "chrome/common/page_load_metrics/page_load_timing.h"
12 #include "content/public/renderer/render_frame_observer.h" 12 #include "content/public/renderer/render_frame_observer.h"
13 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h" 13 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
14 14
15 namespace base { 15 namespace base {
16 class Timer; 16 class Timer;
17 } // namespace base 17 } // namespace base
18 18
19 namespace page_load_metrics { 19 namespace page_load_metrics {
20 20
21 class PageTimingMetricsSender; 21 class PageTimingMetricsSender;
22 class PageTimingSender;
23 22
24 // MetricsRenderFrameObserver observes RenderFrame notifications, and sends page 23 // MetricsRenderFrameObserver observes RenderFrame notifications, and sends page
25 // load timing information to the browser process over IPC. A 24 // load timing information to the browser process over IPC. A
26 // MetricsRenderFrameObserver is instantiated for each frame (main frames and 25 // MetricsRenderFrameObserver is instantiated for each frame (main frames and
27 // child frames). MetricsRenderFrameObserver dispatches timing and metadata 26 // child frames). MetricsRenderFrameObserver dispatches timing and metadata
28 // updates for main frames, but only metadata updates for child frames. 27 // updates for main frames, but only metadata updates for child frames.
29 class MetricsRenderFrameObserver : public content::RenderFrameObserver { 28 class MetricsRenderFrameObserver : public content::RenderFrameObserver {
30 public: 29 public:
31 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame); 30 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame);
32 ~MetricsRenderFrameObserver() override; 31 ~MetricsRenderFrameObserver() override;
33 32
34 // RenderFrameObserver implementation 33 // RenderFrameObserver implementation
35 void DidChangePerformanceTiming() override; 34 void DidChangePerformanceTiming() override;
36 void DidObserveLoadingBehavior( 35 void DidObserveLoadingBehavior(
37 blink::WebLoadingBehaviorFlag behavior) override; 36 blink::WebLoadingBehaviorFlag behavior) override;
38 void DidCommitProvisionalLoad(bool is_new_navigation, 37 void DidCommitProvisionalLoad(bool is_new_navigation,
39 bool is_same_document_navigation) override; 38 bool is_same_document_navigation) override;
40 void OnDestruct() override; 39 void OnDestruct() override;
41 40
42 // Invoked when a frame is going away. This is our last chance to send IPCs 41 // Invoked when a frame is going away. This is our last chance to send IPCs
43 // before being destroyed. 42 // before being destroyed.
44 void FrameDetached() override; 43 void FrameDetached() override;
45 44
46 private: 45 private:
46 // Will be null when we're not actively sending metrics.
47 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
48
47 void SendMetrics(); 49 void SendMetrics();
48 virtual bool ShouldSendMetrics() const; 50 virtual bool ShouldSendMetrics() const;
49 virtual mojom::PageLoadTimingPtr GetTiming() const; 51 virtual mojom::PageLoadTimingPtr GetTiming() const;
50 virtual std::unique_ptr<base::Timer> CreateTimer() const; 52 virtual std::unique_ptr<base::Timer> CreateTimer() const;
51 virtual std::unique_ptr<PageTimingSender> CreatePageTimingSender();
52 virtual bool HasNoRenderFrame() const; 53 virtual bool HasNoRenderFrame() const;
53 54
54 // Will be null when we're not actively sending metrics.
55 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
56
57 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver); 55 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);
58 }; 56 };
59 57
60 } // namespace page_load_metrics 58 } // namespace page_load_metrics
61 59
62 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 60 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698