Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: chrome/renderer/page_load_metrics/fake_page_timing_sender.cc

Issue 2897243002: Revert of [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/fake_page_timing_sender.cc
diff --git a/chrome/renderer/page_load_metrics/fake_page_timing_sender.cc b/chrome/renderer/page_load_metrics/fake_page_timing_sender.cc
deleted file mode 100644
index e41141fd833cbb30f48d25905674aa3298122513..0000000000000000000000000000000000000000
--- a/chrome/renderer/page_load_metrics/fake_page_timing_sender.cc
+++ /dev/null
@@ -1,53 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/renderer/page_load_metrics/fake_page_timing_sender.h"
-
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace page_load_metrics {
-
-FakePageTimingSender::FakePageTimingSender(PageTimingValidator* validator)
- : validator_(validator) {}
-
-FakePageTimingSender::~FakePageTimingSender() {}
-
-void FakePageTimingSender::SendTiming(
- const mojom::PageLoadTimingPtr& timing,
- const mojom::PageLoadMetadataPtr& metadata) {
- validator_->UpdateTiming(timing, metadata);
-}
-
-FakePageTimingSender::PageTimingValidator::PageTimingValidator() {}
-
-FakePageTimingSender::PageTimingValidator::~PageTimingValidator() {
- VerifyExpectedTimings();
-}
-
-void FakePageTimingSender::PageTimingValidator::ExpectPageLoadTiming(
- const mojom::PageLoadTiming& timing) {
- VerifyExpectedTimings();
- expected_timings_.push_back(timing.Clone());
-}
-
-void FakePageTimingSender::PageTimingValidator::VerifyExpectedTimings() const {
- // Ideally we'd just call ASSERT_EQ(actual_timings_, expected_timings_) here,
- // but this causes the generated gtest code to fail to build on Windows. See
- // the comments in the header file for additional details.
- ASSERT_EQ(actual_timings_.size(), expected_timings_.size());
- for (size_t i = 0; i < actual_timings_.size(); ++i) {
- if (actual_timings_.at(i)->Equals(*expected_timings_.at(i)))
- continue;
- ADD_FAILURE() << "Actual timing != expected timing at index " << i;
- }
-}
-
-void FakePageTimingSender::PageTimingValidator::UpdateTiming(
- const mojom::PageLoadTimingPtr& timing,
- const mojom::PageLoadMetadataPtr& metadata) {
- actual_timings_.push_back(timing.Clone());
- VerifyExpectedTimings();
-}
-
-} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698