Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2885203006: [DevTools] inline modules should have correct text offset (Closed)

Created:
3 years, 7 months ago by kozy
Modified:
3 years, 7 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-dom_chromium.org, sof, eae+blinkwatch, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, rwlbuis, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] inline modules should have correct text offset .. otherwise we show them incorrectly in DevTools. BUG=chromium:721589 R=adamk@chromium.org,dgozman@chromium.org Review-Url: https://codereview.chromium.org/2885203006 Cr-Commit-Position: refs/heads/master@{#473131} Committed: https://chromium.googlesource.com/chromium/src/+/99c24962dc687afd137ce69f7efb0a4ae1367301

Patch Set 1 #

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/pause-in-inline-script.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.h View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ModulatorImpl.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ModulatorImpl.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModuleScript.h View 2 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModuleScript.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
kozy
Dmitry and Adam, please take a look.
3 years, 7 months ago (2017-05-18 22:01:53 UTC) #3
adamk
lgtm from a V8 API point of view (it partly takes care of my TODOs), ...
3 years, 7 months ago (2017-05-18 22:30:36 UTC) #5
kouhei (in TOK)
+hiroshige lgtm
3 years, 7 months ago (2017-05-18 23:39:13 UTC) #7
hiroshige
lgtm
3 years, 7 months ago (2017-05-19 00:22:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885203006/20001
3 years, 7 months ago (2017-05-19 00:34:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/431297)
3 years, 7 months ago (2017-05-19 03:08:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885203006/20001
3 years, 7 months ago (2017-05-19 06:45:47 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 08:50:20 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/99c24962dc687afd137ce69f7efb...

Powered by Google App Engine
This is Rietveld 408576698