Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2885203006: [DevTools] inline modules should have correct text offset (Closed)
Patch Set: a Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index cca9ab4a16ddc23270a3e1c1515dc812043d325d..c735b9132165e9b518d870cecb77b56a2a4ddfb1 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -504,14 +504,15 @@ v8::MaybeLocal<v8::Module> V8ScriptRunner::CompileModule(
v8::Isolate* isolate,
const String& source,
const String& file_name,
- AccessControlStatus access_control_status) {
+ AccessControlStatus access_control_status,
+ const TextPosition& start_position) {
TRACE_EVENT1("v8", "v8.compileModule", "fileName", file_name.Utf8());
// TODO(adamk): Add Inspector integration?
// TODO(adamk): Pass more info into ScriptOrigin.
v8::ScriptOrigin origin(
V8String(isolate, file_name),
- v8::Integer::New(isolate, 0), // line_offset
- v8::Integer::New(isolate, 0), // col_offset
+ v8::Integer::New(isolate, start_position.line_.ZeroBasedInt()),
+ v8::Integer::New(isolate, start_position.column_.ZeroBasedInt()),
v8::Boolean::New(isolate, access_control_status == kSharableCrossOrigin),
v8::Local<v8::Integer>(), // script id
v8::String::Empty(isolate), // source_map_url
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h ('k') | third_party/WebKit/Source/core/dom/Modulator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698