Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

Issue 2885203006: [DevTools] inline modules should have correct text offset (Closed)
Patch Set: a Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp
index acd18ec4fe382d94323ed0b520198efaea9449cf..349a8dd01921ea66d6433a5f527868ab5bdeb5c4 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp
@@ -38,7 +38,8 @@ ScriptModule::~ScriptModule() {}
ScriptModule ScriptModule::Compile(v8::Isolate* isolate,
const String& source,
const String& file_name,
- AccessControlStatus access_control_status) {
+ AccessControlStatus access_control_status,
+ const TextPosition& start_position) {
// We ensure module-related code is not executed without the flag.
// https://crbug.com/715376
CHECK(RuntimeEnabledFeatures::moduleScriptsEnabled());
@@ -47,7 +48,7 @@ ScriptModule ScriptModule::Compile(v8::Isolate* isolate,
try_catch.SetVerbose(true);
v8::Local<v8::Module> module;
if (!V8ScriptRunner::CompileModule(isolate, source, file_name,
- access_control_status)
+ access_control_status, start_position)
.ToLocal(&module)) {
// Compilation error is not used in Blink implementaion logic.
// Note: Error message is delivered to user (e.g. console) by message
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptModule.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698