Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/core/dom/ModuleScript.cpp

Issue 2885203006: [DevTools] inline modules should have correct text offset (Closed)
Patch Set: a Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ModuleScript.cpp
diff --git a/third_party/WebKit/Source/core/dom/ModuleScript.cpp b/third_party/WebKit/Source/core/dom/ModuleScript.cpp
index 3709f7e9f27326889da3032aa28ec7fab72e8488..1af90230c76e58cdaad29fdb791ae100b821a452 100644
--- a/third_party/WebKit/Source/core/dom/ModuleScript.cpp
+++ b/third_party/WebKit/Source/core/dom/ModuleScript.cpp
@@ -18,7 +18,8 @@ ModuleScript* ModuleScript::Create(
const String& nonce,
ParserDisposition parser_state,
WebURLRequest::FetchCredentialsMode credentials_mode,
- AccessControlStatus access_control_status) {
+ AccessControlStatus access_control_status,
+ const TextPosition& start_position) {
// https://html.spec.whatwg.org/#creating-a-module-script
// Step 1. Let script be a new module script that this algorithm will
// subsequently initialize.
@@ -28,7 +29,7 @@ ModuleScript* ModuleScript::Create(
// Delegate to Modulator::compileModule to process Steps 3-6.
ScriptModule result = modulator->CompileModule(
- source_text, base_url.GetString(), access_control_status);
+ source_text, base_url.GetString(), access_control_status, start_position);
// Step 6: "...return null, and abort these steps."
if (result.IsNull())
return nullptr;
« no previous file with comments | « third_party/WebKit/Source/core/dom/ModuleScript.h ('k') | third_party/WebKit/Source/core/dom/ScriptLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698