third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h - Issue 2885203006: [DevTools] inline modules should have correct text offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

Issue 2885203006: [DevTools] inline modules should have correct text offset (Closed)

Patch Set: a Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

index d8e294b6398f8238913298d82126bb4518132d8e..80442abc7a5258f00c1e0a013430365e982a5b69 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

@@ -82,7 +82,8 @@ class CORE_EXPORT V8ScriptRunner final {

static v8::MaybeLocal<v8::Module> CompileModule(v8::Isolate*,

const String& source,

const String& file_name,

- AccessControlStatus);

+ AccessControlStatus,

+ const TextPosition&);

static v8::MaybeLocal<v8::Value> RunCompiledScript(v8::Isolate*,

v8::Local<v8::Script>,

ExecutionContext*);