Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: third_party/WebKit/Source/core/dom/ModulatorImpl.cpp

Issue 2885203006: [DevTools] inline modules should have correct text offset (Closed)
Patch Set: a Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ModulatorImpl.cpp
diff --git a/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp b/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp
index 546f5d51b280e59045035b0432f160181132cdda..5d43e9bcba7dd725c64033b2b74540315247409b 100644
--- a/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp
+++ b/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp
@@ -118,7 +118,8 @@ bool ModulatorImpl::HasValidContext() {
ScriptModule ModulatorImpl::CompileModule(
const String& provided_source,
const String& url_str,
- AccessControlStatus access_control_status) {
+ AccessControlStatus access_control_status,
+ const TextPosition& position) {
// Implements Steps 3-6 of
// https://html.spec.whatwg.org/multipage/webappapis.html#creating-a-module-script
@@ -138,7 +139,7 @@ ScriptModule ModulatorImpl::CompileModule(
// Note: reporting is routed via V8Initializer::messageHandlerInMainThread.
ScriptState::Scope scope(script_state_.Get());
return ScriptModule::Compile(script_state_->GetIsolate(), script_source,
- url_str, access_control_status);
+ url_str, access_control_status, position);
}
ScriptValue ModulatorImpl::InstantiateModule(ScriptModule script_module) {
« no previous file with comments | « third_party/WebKit/Source/core/dom/ModulatorImpl.h ('k') | third_party/WebKit/Source/core/dom/ModuleScript.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698