Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/Source/core/dom/ModuleScript.h

Issue 2885203006: [DevTools] inline modules should have correct text offset (Closed)
Patch Set: a Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ModuleScript.h
diff --git a/third_party/WebKit/Source/core/dom/ModuleScript.h b/third_party/WebKit/Source/core/dom/ModuleScript.h
index 029e486a4058d69636d4729e002016d37648d86a..76e42e8c1b7ac184eef3e0777b1db62752499abc 100644
--- a/third_party/WebKit/Source/core/dom/ModuleScript.h
+++ b/third_party/WebKit/Source/core/dom/ModuleScript.h
@@ -15,6 +15,7 @@
#include "platform/heap/Handle.h"
#include "platform/loader/fetch/ResourceLoaderOptions.h"
#include "platform/weborigin/KURL.h"
+#include "platform/wtf/text/TextPosition.h"
#include "public/platform/WebURLRequest.h"
namespace blink {
@@ -31,13 +32,15 @@ enum class ModuleInstantiationState {
class CORE_EXPORT ModuleScript final : public Script, public TraceWrapperBase {
public:
// https://html.spec.whatwg.org/#creating-a-module-script
- static ModuleScript* Create(const String& source_text,
- Modulator*,
- const KURL& base_url,
- const String& nonce,
- ParserDisposition,
- WebURLRequest::FetchCredentialsMode,
- AccessControlStatus);
+ static ModuleScript* Create(
+ const String& source_text,
+ Modulator*,
+ const KURL& base_url,
+ const String& nonce,
+ ParserDisposition,
+ WebURLRequest::FetchCredentialsMode,
+ AccessControlStatus,
+ const TextPosition& start_position = TextPosition::MinimumPosition());
// Mostly corresponds to Create() but accepts ScriptModule as the argument
// and allows null ScriptModule.
« no previous file with comments | « third_party/WebKit/Source/core/dom/ModulatorImpl.cpp ('k') | third_party/WebKit/Source/core/dom/ModuleScript.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698