third_party/WebKit/Source/core/dom/ModulatorImpl.h - Issue 2885203006: [DevTools] inline modules should have correct text offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ModulatorImpl.h

Issue 2885203006: [DevTools] inline modules should have correct text offset (Closed)

Patch Set: a Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ModulatorImpl.h

diff --git a/third_party/WebKit/Source/core/dom/ModulatorImpl.h b/third_party/WebKit/Source/core/dom/ModulatorImpl.h

index 6f7d4b77353ffe1c9dc6e5dd358d6cfc184ad385..fe7d7527a71b900b02547d10757fbc3cca08bae8 100644

--- a/third_party/WebKit/Source/core/dom/ModulatorImpl.h

+++ b/third_party/WebKit/Source/core/dom/ModulatorImpl.h

@@ -61,7 +61,8 @@ class ModulatorImpl final : public Modulator {

ModuleScriptLoaderClient*) override;

ScriptModule CompileModule(const String& script,

const String& url_str,

- AccessControlStatus) override;

+ AccessControlStatus,

+ const TextPosition&) override;

ScriptValue InstantiateModule(ScriptModule) override;

ScriptValue GetInstantiationError(const ModuleScript*) override;

Vector<String> ModuleRequestsFromScriptModule(ScriptModule) override;