Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2851993002: Move more methods from WebViewImpl to WebViewBase, and cut dependencies. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews, dcheng, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more methods from WebViewImpl to WebViewBase, and cut dependencies. The work continues the effort to remove direct dependencies on web/WebViewImpl.h by moving methods to a pure virtual base class, and updating references to use the base class rather than the implementation. We need to break cyclic dependencies in web/ to allow us to move files up into core/ and modules/. BUG=712963 Review-Url: https://codereview.chromium.org/2851993002 Cr-Commit-Position: refs/heads/master@{#468307} Committed: https://chromium.googlesource.com/chromium/src/+/11511f6be6df08006e6a8c471eefef6f251a652e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -36 lines) Patch
M third_party/WebKit/Source/core/exported/WebViewBase.h View 3 chunks +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 5 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 8 chunks +21 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
slangley
3 years, 7 months ago (2017-05-01 03:02:49 UTC) #2
haraken
LGTM
3 years, 7 months ago (2017-05-01 08:51:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851993002/1
3 years, 7 months ago (2017-05-01 11:16:41 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 11:21:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/11511f6be6df08006e6a8c471eef...

Powered by Google App Engine
This is Rietveld 408576698