Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 2851993002: Move more methods from WebViewImpl to WebViewBase, and cut dependencies. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.h
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h
index d6d68b2b579abbac363a30a58f7b14a538b39c9d..063f72b2cdc5c6dd9a828fcfd0fe7d2fc8debe83 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.h
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h
@@ -42,13 +42,13 @@ namespace blink {
class PagePopup;
class PagePopupClient;
-class WebViewImpl;
+class WebViewBase;
struct WebCursorInfo;
// Handles window-level notifications from core on behalf of a WebView.
class WEB_EXPORT ChromeClientImpl final : public ChromeClient {
public:
- static ChromeClientImpl* Create(WebViewImpl*);
+ static ChromeClientImpl* Create(WebViewBase*);
~ChromeClientImpl() override;
void* WebView() const override;
@@ -236,13 +236,13 @@ class WEB_EXPORT ChromeClientImpl final : public ChromeClient {
WebLayerTreeView* GetWebLayerTreeView(LocalFrame*) override;
private:
- explicit ChromeClientImpl(WebViewImpl*);
+ explicit ChromeClientImpl(WebViewBase*);
bool IsChromeClientImpl() const override { return true; }
void SetCursor(const WebCursorInfo&, LocalFrame*);
- WebViewImpl* web_view_; // Weak pointer.
+ WebViewBase* web_view_; // Weak pointer.
WindowFeatures window_features_;
Vector<PopupOpeningObserver*> popup_opening_observers_;
Cursor last_set_mouse_cursor_for_testing_;
« no previous file with comments | « third_party/WebKit/Source/core/exported/WebViewBase.h ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698