third_party/WebKit/Source/web/PopupMenuImpl.cpp - Issue 2851993002: Move more methods from WebViewImpl to WebViewBase, and cut dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 2851993002: Move more methods from WebViewImpl to WebViewBase, and cut dependencies. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp

diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

index fcb0db78a39a26bfc7fdb06c66d47e5567de08ee..2b0cd8df2cd049bfa80c74726b59c3c9a446757e 100644

--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp

+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

@@ -11,6 +11,7 @@

#include "core/dom/StyleEngine.h"

#include "core/dom/TaskRunnerHelper.h"

#include "core/events/ScopedEventQueue.h"

+#include "core/exported/WebViewBase.h"

#include "core/frame/FrameView.h"

#include "core/frame/LocalFrame.h"

#include "core/html/HTMLHRElement.h"

@@ -23,9 +24,9 @@

#include "platform/geometry/IntRect.h"

#include "platform/text/PlatformLocale.h"

#include "public/platform/Platform.h"

+#include "public/platform/WebMouseEvent.h"

#include "public/web/WebColorChooser.h"

#include "web/ChromeClientImpl.h"

-#include "web/WebViewImpl.h"

namespace blink {