Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2851993002: Move more methods from WebViewImpl to WebViewBase, and cut dependencies. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 31b8efb1e4a0fbcfc86b4816ed5a7c8faaa38ae7..7e866d1a03178c89f6d3dae2a3ecc70a4b844ff4 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -1770,6 +1770,10 @@ Frame* WebViewImpl::FocusedCoreFrame() const {
return page_ ? page_->GetFocusController().FocusedOrMainFrame() : nullptr;
}
+WebViewBase* WebViewBase::FromPage(Page* page) {
+ return WebViewImpl::FromPage(page);
+}
+
WebViewImpl* WebViewImpl::FromPage(Page* page) {
return page ? static_cast<WebViewImpl*>(page->GetChromeClient().WebView())
: nullptr;
@@ -3725,6 +3729,10 @@ void WebViewImpl::MainFrameScrollOffsetChanged() {
dev_tools_emulator_->MainFrameScrollOrScaleChanged();
}
+bool WebViewBase::UseExternalPopupMenus() {
+ return WebViewImpl::UseExternalPopupMenus();
+}
+
bool WebViewImpl::UseExternalPopupMenus() {
return g_should_use_external_popup_menus;
}
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698