Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.h

Issue 2851993002: Move more methods from WebViewImpl to WebViewBase, and cut dependencies. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/PopupMenuImpl.cpp ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebPagePopupImpl.h
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.h b/third_party/WebKit/Source/web/WebPagePopupImpl.h
index 38f21b3109658e7909457c2e006540965a9e3126..305cc55a5ab71f868f24a32d58827b3dc18a4b39 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.h
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.h
@@ -48,7 +48,7 @@ class PagePopupChromeClient;
class PagePopupClient;
class WebLayerTreeView;
class WebLayer;
-class WebViewImpl;
+class WebViewBase;
class LocalDOMWindow;
class WebPagePopupImpl final : public WebPagePopup,
@@ -60,7 +60,7 @@ class WebPagePopupImpl final : public WebPagePopup,
public:
~WebPagePopupImpl() override;
- bool Initialize(WebViewImpl*, PagePopupClient*);
+ bool Initialize(WebViewBase*, PagePopupClient*);
void ClosePopup();
WebWidgetClient* WidgetClient() const { return widget_client_; }
bool HasSamePopupClient(WebPagePopupImpl* other) {
@@ -115,7 +115,7 @@ class WebPagePopupImpl final : public WebPagePopup,
WebRect WindowRectInScreen() const;
WebWidgetClient* widget_client_;
- WebViewImpl* web_view_;
+ WebViewBase* web_view_;
Persistent<Page> page_;
Persistent<PagePopupChromeClient> chrome_client_;
PagePopupClient* popup_client_;
« no previous file with comments | « third_party/WebKit/Source/web/PopupMenuImpl.cpp ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698