Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2851993002: Move more methods from WebViewImpl to WebViewBase, and cut dependencies. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/PopupMenuImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index fe305d710d0976991055240956d2968d912944f3..b60e37ae23384a45b01125d9fffad117a3bac29c 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -171,14 +171,14 @@ static WebAXEvent ToWebAXEvent(AXObjectCache::AXNotification notification) {
return static_cast<WebAXEvent>(notification);
}
-ChromeClientImpl::ChromeClientImpl(WebViewImpl* web_view)
+ChromeClientImpl::ChromeClientImpl(WebViewBase* web_view)
: web_view_(web_view),
cursor_overridden_(false),
did_request_non_empty_tool_tip_(false) {}
ChromeClientImpl::~ChromeClientImpl() {}
-ChromeClientImpl* ChromeClientImpl::Create(WebViewImpl* web_view) {
+ChromeClientImpl* ChromeClientImpl::Create(WebViewBase* web_view) {
return new ChromeClientImpl(web_view);
}
@@ -187,7 +187,7 @@ void* ChromeClientImpl::WebView() const {
}
void ChromeClientImpl::ChromeDestroyed() {
- // Our lifetime is bound to the WebViewImpl.
+ // Our lifetime is bound to the WebViewBase.
}
void ChromeClientImpl::SetWindowRect(const IntRect& r, LocalFrame& frame) {
@@ -910,7 +910,7 @@ bool ChromeClientImpl::HasOpenedPopup() const {
PopupMenu* ChromeClientImpl::OpenPopupMenu(LocalFrame& frame,
HTMLSelectElement& select) {
NotifyPopupOpeningObservers();
- if (WebViewImpl::UseExternalPopupMenus())
+ if (WebViewBase::UseExternalPopupMenus())
return new ExternalPopupMenu(frame, select, *web_view_);
DCHECK(RuntimeEnabledFeatures::pagePopupEnabled());
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/PopupMenuImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698