Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2851993002: Move more methods from WebViewImpl to WebViewBase, and cut dependencies. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "web/WebRemoteFrameImpl.h" 5 #include "web/WebRemoteFrameImpl.h"
6 6
7 #include "bindings/core/v8/DOMWrapperWorld.h" 7 #include "bindings/core/v8/DOMWrapperWorld.h"
8 #include "bindings/core/v8/WindowProxy.h" 8 #include "bindings/core/v8/WindowProxy.h"
9 #include "core/dom/Fullscreen.h" 9 #include "core/dom/Fullscreen.h"
10 #include "core/dom/RemoteSecurityContext.h" 10 #include "core/dom/RemoteSecurityContext.h"
11 #include "core/dom/SecurityContext.h" 11 #include "core/dom/SecurityContext.h"
12 #include "core/exported/WebViewBase.h"
12 #include "core/frame/FrameView.h" 13 #include "core/frame/FrameView.h"
13 #include "core/frame/Settings.h" 14 #include "core/frame/Settings.h"
14 #include "core/frame/csp/ContentSecurityPolicy.h" 15 #include "core/frame/csp/ContentSecurityPolicy.h"
15 #include "core/html/HTMLFrameOwnerElement.h" 16 #include "core/html/HTMLFrameOwnerElement.h"
16 #include "core/layout/LayoutObject.h" 17 #include "core/layout/LayoutObject.h"
17 #include "core/page/Page.h" 18 #include "core/page/Page.h"
18 #include "platform/feature_policy/FeaturePolicy.h" 19 #include "platform/feature_policy/FeaturePolicy.h"
19 #include "platform/heap/Handle.h" 20 #include "platform/heap/Handle.h"
20 #include "public/platform/WebFeaturePolicy.h" 21 #include "public/platform/WebFeaturePolicy.h"
21 #include "public/platform/WebFloatRect.h" 22 #include "public/platform/WebFloatRect.h"
22 #include "public/platform/WebRect.h" 23 #include "public/platform/WebRect.h"
23 #include "public/web/WebDocument.h" 24 #include "public/web/WebDocument.h"
24 #include "public/web/WebFrameOwnerProperties.h" 25 #include "public/web/WebFrameOwnerProperties.h"
25 #include "public/web/WebPerformance.h" 26 #include "public/web/WebPerformance.h"
26 #include "public/web/WebRange.h" 27 #include "public/web/WebRange.h"
27 #include "public/web/WebTreeScopeType.h" 28 #include "public/web/WebTreeScopeType.h"
28 #include "v8/include/v8.h" 29 #include "v8/include/v8.h"
29 #include "web/RemoteFrameOwner.h" 30 #include "web/RemoteFrameOwner.h"
30 #include "web/WebLocalFrameImpl.h" 31 #include "web/WebLocalFrameImpl.h"
31 #include "web/WebViewImpl.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 WebRemoteFrame* WebRemoteFrame::Create(WebTreeScopeType scope, 35 WebRemoteFrame* WebRemoteFrame::Create(WebTreeScopeType scope,
36 WebRemoteFrameClient* client, 36 WebRemoteFrameClient* client,
37 WebFrame* opener) { 37 WebFrame* opener) {
38 return WebRemoteFrameImpl::Create(scope, client, opener); 38 return WebRemoteFrameImpl::Create(scope, client, opener);
39 } 39 }
40 40
41 WebRemoteFrameImpl* WebRemoteFrameImpl::Create(WebTreeScopeType scope, 41 WebRemoteFrameImpl* WebRemoteFrameImpl::Create(WebTreeScopeType scope,
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 } 130 }
131 131
132 bool WebRemoteFrameImpl::HasVerticalScrollbar() const { 132 bool WebRemoteFrameImpl::HasVerticalScrollbar() const {
133 NOTREACHED(); 133 NOTREACHED();
134 return false; 134 return false;
135 } 135 }
136 136
137 WebView* WebRemoteFrameImpl::View() const { 137 WebView* WebRemoteFrameImpl::View() const {
138 if (!GetFrame()) 138 if (!GetFrame())
139 return nullptr; 139 return nullptr;
140 return WebViewImpl::FromPage(GetFrame()->GetPage()); 140 return WebViewBase::FromPage(GetFrame()->GetPage());
141 } 141 }
142 142
143 WebDocument WebRemoteFrameImpl::GetDocument() const { 143 WebDocument WebRemoteFrameImpl::GetDocument() const {
144 // TODO(dcheng): this should also ASSERT_NOT_REACHED, but a lot of 144 // TODO(dcheng): this should also ASSERT_NOT_REACHED, but a lot of
145 // code tries to access the document of a remote frame at the moment. 145 // code tries to access the document of a remote frame at the moment.
146 return WebDocument(); 146 return WebDocument();
147 } 147 }
148 148
149 WebPerformance WebRemoteFrameImpl::Performance() const { 149 WebPerformance WebRemoteFrameImpl::Performance() const {
150 NOTREACHED(); 150 NOTREACHED();
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 } 536 }
537 537
538 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope, 538 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope,
539 WebRemoteFrameClient* client) 539 WebRemoteFrameClient* client)
540 : WebRemoteFrame(scope), 540 : WebRemoteFrame(scope),
541 frame_client_(RemoteFrameClientImpl::Create(this)), 541 frame_client_(RemoteFrameClientImpl::Create(this)),
542 client_(client), 542 client_(client),
543 self_keep_alive_(this) {} 543 self_keep_alive_(this) {}
544 544
545 } // namespace blink 545 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebPagePopupImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698