Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 2851993002: Move more methods from WebViewImpl to WebViewBase, and cut dependencies. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 24 matching lines...) Expand all
35 #include "core/page/ChromeClient.h" 35 #include "core/page/ChromeClient.h"
36 #include "core/page/WindowFeatures.h" 36 #include "core/page/WindowFeatures.h"
37 #include "public/web/WebNavigationPolicy.h" 37 #include "public/web/WebNavigationPolicy.h"
38 #include "web/WebExport.h" 38 #include "web/WebExport.h"
39 #include <memory> 39 #include <memory>
40 40
41 namespace blink { 41 namespace blink {
42 42
43 class PagePopup; 43 class PagePopup;
44 class PagePopupClient; 44 class PagePopupClient;
45 class WebViewImpl; 45 class WebViewBase;
46 struct WebCursorInfo; 46 struct WebCursorInfo;
47 47
48 // Handles window-level notifications from core on behalf of a WebView. 48 // Handles window-level notifications from core on behalf of a WebView.
49 class WEB_EXPORT ChromeClientImpl final : public ChromeClient { 49 class WEB_EXPORT ChromeClientImpl final : public ChromeClient {
50 public: 50 public:
51 static ChromeClientImpl* Create(WebViewImpl*); 51 static ChromeClientImpl* Create(WebViewBase*);
52 ~ChromeClientImpl() override; 52 ~ChromeClientImpl() override;
53 53
54 void* WebView() const override; 54 void* WebView() const override;
55 55
56 // ChromeClient methods: 56 // ChromeClient methods:
57 void ChromeDestroyed() override; 57 void ChromeDestroyed() override;
58 void SetWindowRect(const IntRect&, LocalFrame&) override; 58 void SetWindowRect(const IntRect&, LocalFrame&) override;
59 IntRect RootWindowRect() override; 59 IntRect RootWindowRect() override;
60 IntRect PageRect() override; 60 IntRect PageRect() override;
61 void Focus() override; 61 void Focus() override;
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 229
230 void RegisterPopupOpeningObserver(PopupOpeningObserver*) override; 230 void RegisterPopupOpeningObserver(PopupOpeningObserver*) override;
231 void UnregisterPopupOpeningObserver(PopupOpeningObserver*) override; 231 void UnregisterPopupOpeningObserver(PopupOpeningObserver*) override;
232 void NotifyPopupOpeningObservers() const; 232 void NotifyPopupOpeningObservers() const;
233 233
234 void InstallSupplements(LocalFrame&) override; 234 void InstallSupplements(LocalFrame&) override;
235 235
236 WebLayerTreeView* GetWebLayerTreeView(LocalFrame*) override; 236 WebLayerTreeView* GetWebLayerTreeView(LocalFrame*) override;
237 237
238 private: 238 private:
239 explicit ChromeClientImpl(WebViewImpl*); 239 explicit ChromeClientImpl(WebViewBase*);
240 240
241 bool IsChromeClientImpl() const override { return true; } 241 bool IsChromeClientImpl() const override { return true; }
242 242
243 void SetCursor(const WebCursorInfo&, LocalFrame*); 243 void SetCursor(const WebCursorInfo&, LocalFrame*);
244 244
245 WebViewImpl* web_view_; // Weak pointer. 245 WebViewBase* web_view_; // Weak pointer.
246 WindowFeatures window_features_; 246 WindowFeatures window_features_;
247 Vector<PopupOpeningObserver*> popup_opening_observers_; 247 Vector<PopupOpeningObserver*> popup_opening_observers_;
248 Cursor last_set_mouse_cursor_for_testing_; 248 Cursor last_set_mouse_cursor_for_testing_;
249 bool cursor_overridden_; 249 bool cursor_overridden_;
250 bool did_request_non_empty_tool_tip_; 250 bool did_request_non_empty_tool_tip_;
251 }; 251 };
252 252
253 DEFINE_TYPE_CASTS(ChromeClientImpl, 253 DEFINE_TYPE_CASTS(ChromeClientImpl,
254 ChromeClient, 254 ChromeClient,
255 client, 255 client,
256 client->IsChromeClientImpl(), 256 client->IsChromeClientImpl(),
257 client.IsChromeClientImpl()); 257 client.IsChromeClientImpl());
258 258
259 } // namespace blink 259 } // namespace blink
260 260
261 #endif 261 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/exported/WebViewBase.h ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698