Move ScriptWrappable and dependencies to platform/bindings

Move ScriptWrappable and dependencies to platform/bindings

This CL moves ScriptWrappable.h/cpp and all its dependencies to platform/bindings. The
original header for each file is not deleted, but is modified to point to the new header
in platform/bindings (This will be cleaned up in follow-up CLs).

BUG=682322
Review-Url: https://codereview.chromium.org/2843603002
Cr-Commit-Position: refs/heads/master@{#467719}
Committed: https://chromium.googlesource.com/chromium/src/+/594ca9154ab4c2597ea11b8d6bc6d873274a79ce

[adithyas, 2017-04-24 21:42:44]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 21:43:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 22:37:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 22:37:05]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[adithyas, 2017-04-25 19:08:49]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 19:10:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 20:50:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 20:50:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[adithyas, 2017-04-25 21:40:34]

adithyas@chromium.org changed reviewers:
+ haraken@chromium.org, jbroman@chromium.org

[jbroman, 2017-04-25 21:45:35]

Will have a closer look tomorrow, but saw one thing at a glance.

https://codereview.chromium.org/2843603002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/bindings/ScriptWrappable.h (right):

https://codereview.chromium.org/2843603002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/bindings/ScriptWrappable.h:2: * Copyright (C)
2017 Google Inc. All rights reserved.
Here and elsewhere: don't update copyright headers.

https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

[haraken, 2017-04-26 01:19:46]

LGTM with jbroman's comment addressed.

[adithyas, 2017-04-26 19:44:50]

https://codereview.chromium.org/2843603002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/bindings/ScriptWrappable.h (right):

https://codereview.chromium.org/2843603002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/bindings/ScriptWrappable.h:2: * Copyright (C)
2017 Google Inc. All rights reserved.
On 2017/04/25 at 21:45:34, jbroman wrote:
> Here and elsewhere: don't update copyright headers.
> 
>
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

Done.

[jbroman, 2017-04-26 19:48:21]

A platform/bindings/README.md would be nice, but lgtm regardless.

[adithyas, 2017-04-26 20:02:07]

On 2017/04/26 at 19:48:21, jbroman wrote:
> A platform/bindings/README.md would be nice, but lgtm regardless.

Sure! There are a couple of markdown files in bindings/core/v8/ that document
trace wrapping (TraceWrapperReference.md) and the design of binding architecture
(V8BindingDesign.md). I guess they now belong in platform/bindings, so I'll move
them in a follow-up. Do you think a README.md is needed on top of that?

[jbroman, 2017-04-26 20:08:56]

On 2017/04/26 at 20:02:07, adithyas wrote:
> On 2017/04/26 at 19:48:21, jbroman wrote:
> > A platform/bindings/README.md would be nice, but lgtm regardless.
> 
> Sure! There are a couple of markdown files in bindings/core/v8/ that document
trace wrapping (TraceWrapperReference.md) and the design of binding architecture
(V8BindingDesign.md). I guess they now belong in platform/bindings, so I'll move
them in a follow-up. Do you think a README.md is needed on top of that?

Ideally each source directory would have at least a short README.md that answers
the question "what is this directory for". Something along the lines of "This
directory contains low-level functionality for wrapping a Blink C++ object with
a JavaScript object (see ScriptWrappable.h), and utilities for interfacing
between Blink platform types and V8 types (see V8Binding.h)." A little more
detail might be ideal, but having these around makes it easier to orient oneself
when one doesn't really know what "platform bindings" might mean.

[adithyas, 2017-04-26 20:13:17]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-04-26 20:13:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2843603002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-26 20:14:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 23:19:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 23:19:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[adithyas, 2017-04-27 15:00:34]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-04-27 15:00:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2843603002/#ps140001
(title: "Rebase and try again")

[commit-bot: I haz the power, 2017-04-27 15:01:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 17:42:25]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493305234370370,
"parent_rev": "396aeae063fa2f8a1e7422bc86a568239bf8fca4", "commit_rev":
"594ca9154ab4c2597ea11b8d6bc6d873274a79ce"}

[commit-bot: I haz the power, 2017-04-27 17:42:45]

Description was changed from

==========
Move ScriptWrappable and dependencies to platform/bindings

This CL moves ScriptWrappable.h/cpp and all its dependencies to
platform/bindings. The
original header for each file is not deleted, but is modified to point to the
new header
in platform/bindings (This will be cleaned up in follow-up CLs).

BUG=682322
==========

to

==========
Move ScriptWrappable and dependencies to platform/bindings

This CL moves ScriptWrappable.h/cpp and all its dependencies to
platform/bindings. The
original header for each file is not deleted, but is modified to point to the
new header
in platform/bindings (This will be cleaned up in follow-up CLs).

BUG=682322

Review-Url: https://codereview.chromium.org/2843603002
Cr-Commit-Position: refs/heads/master@{#467719}
Committed:
https://chromium.googlesource.com/chromium/src/+/594ca9154ab4c2597ea11b8d6bc6...
==========

[commit-bot: I haz the power, 2017-04-27 17:42:47]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/594ca9154ab4c2597ea11b8d6bc6...