Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GlobalValueMap.h

Issue 2843603002: Move ScriptWrappable and dependencies to platform/bindings (Closed)
Patch Set: Rebase and try again Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8GlobalValueMap.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GlobalValueMap.h b/third_party/WebKit/Source/bindings/core/v8/V8GlobalValueMap.h
index db4a2e590f73f2a1039e3c7837ac9cc79e770650..12b9118f460f5859f3b23bc38ecd9b9b78181472 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GlobalValueMap.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GlobalValueMap.h
@@ -2,117 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef V8GlobalValueMap_h
-#define V8GlobalValueMap_h
-
-#include "platform/wtf/Allocator.h"
-#include "platform/wtf/HashMap.h"
-#include "platform/wtf/text/StringHash.h"
-#include "v8-util.h"
-#include "v8/include/v8.h"
-
-namespace blink {
-
-/**
- * A Traits class for v8::GlobalValueMap that uses wtf/HashMap as a
- * backing store.
- *
- * The parameter is_weak will determine whether the references are 'weak'.
- * If so, entries will be removed from the map as the weak references are
- * collected.
- */
-template <class KeyType,
- class ValueType,
- v8::PersistentContainerCallbackType type>
-class V8GlobalValueMapTraits {
- STATIC_ONLY(V8GlobalValueMapTraits);
-
- public:
- // Map traits:
- typedef HashMap<KeyType, v8::PersistentContainerValue> Impl;
- typedef typename Impl::iterator Iterator;
- static size_t Size(const Impl* impl) { return impl->size(); }
- static bool Empty(Impl* impl) { return impl->IsEmpty(); }
- static void Swap(Impl& impl, Impl& other) { impl.swap(other); }
- static Iterator Begin(Impl* impl) { return impl->begin(); }
- static Iterator End(Impl* impl) { return impl->end(); }
- static v8::PersistentContainerValue Value(Iterator& iter) {
- return iter->value;
- }
- static KeyType Key(Iterator& iter) { return iter->key; }
- static v8::PersistentContainerValue Set(Impl* impl,
- KeyType key,
- v8::PersistentContainerValue value) {
- v8::PersistentContainerValue old_value = Get(impl, key);
- impl->Set(key, value);
- return old_value;
- }
- static v8::PersistentContainerValue Get(const Impl* impl, KeyType key) {
- return impl->at(key);
- }
-
- static v8::PersistentContainerValue Remove(Impl* impl, KeyType key) {
- return impl->Take(key);
- }
-
- // Weak traits:
- static const v8::PersistentContainerCallbackType kCallbackType = type;
- typedef v8::GlobalValueMap<KeyType,
- ValueType,
- V8GlobalValueMapTraits<KeyType, ValueType, type>>
- MapType;
-
- typedef void WeakCallbackDataType;
-
- static WeakCallbackDataType* WeakCallbackParameter(
- MapType* map,
- KeyType key,
- const v8::Local<ValueType>& value) {
- return 0;
- }
-
- static void DisposeCallbackData(WeakCallbackDataType* callback_data) {}
-
- static MapType* MapFromWeakCallbackInfo(
- const v8::WeakCallbackInfo<WeakCallbackDataType>& data) {
- return 0;
- }
-
- static KeyType KeyFromWeakCallbackInfo(
- const v8::WeakCallbackInfo<WeakCallbackDataType>& data) {
- return KeyType();
- }
-
- static void OnWeakCallback(
- const v8::WeakCallbackInfo<WeakCallbackDataType>& data) {}
-
- // Dispose traits:
- static void Dispose(v8::Isolate* isolate,
- v8::Global<ValueType> value,
- KeyType key) {}
- static void DisposeWeak(
- const v8::WeakCallbackInfo<WeakCallbackDataType>& data) {}
-};
-
-/**
- * A map for safely storing persistent V8 values, based on
- * v8::GlobalValueMap.
- */
-template <class KeyType,
- class ValueType,
- v8::PersistentContainerCallbackType type>
-class V8GlobalValueMap : public v8::GlobalValueMap<
- KeyType,
- ValueType,
- V8GlobalValueMapTraits<KeyType, ValueType, type>> {
- DISALLOW_NEW();
-
- public:
- typedef V8GlobalValueMapTraits<KeyType, ValueType, type> Traits;
- explicit V8GlobalValueMap(v8::Isolate* isolate)
- : v8::GlobalValueMap<KeyType, ValueType, Traits>(isolate) {}
-};
-
-} // namespace blink
-
-#endif // V8GlobalValueMap_h
+// This file has been moved to platform/bindings/V8GlobalValueMap.h.
+// TODO(adithyas): Remove this file.
+#include "platform/bindings/V8GlobalValueMap.h"

Powered by Google App Engine
This is Rietveld 408576698