Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h

Issue 2843603002: Move ScriptWrappable and dependencies to platform/bindings (Closed)
Patch Set: Rebase and try again Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
index 8c3a550b3c16f45c893241f5ab777ceb6402295a..763866c77e146727bdc6d2183ee3243bbb8707ad 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
@@ -28,124 +28,6 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef V8PerContextData_h
-#define V8PerContextData_h
-
-#include <memory>
-
-#include "bindings/core/v8/ScopedPersistent.h"
-#include "bindings/core/v8/V0CustomElementBinding.h"
-#include "bindings/core/v8/V8GlobalValueMap.h"
-#include "bindings/core/v8/WrapperTypeInfo.h"
-#include "core/CoreExport.h"
-#include "gin/public/context_holder.h"
-#include "gin/public/gin_embedders.h"
-#include "platform/wtf/Allocator.h"
-#include "platform/wtf/HashMap.h"
-#include "platform/wtf/Vector.h"
-#include "platform/wtf/text/AtomicString.h"
-#include "platform/wtf/text/AtomicStringHash.h"
-#include "v8/include/v8.h"
-
-namespace blink {
-
-class V8DOMActivityLogger;
-class V8PerContextData;
-
-enum V8ContextEmbedderDataField {
- kV8ContextPerContextDataIndex =
- static_cast<int>(gin::kPerContextDataStartIndex + gin::kEmbedderBlink),
-};
-
-class CORE_EXPORT V8PerContextData final {
- USING_FAST_MALLOC(V8PerContextData);
- WTF_MAKE_NONCOPYABLE(V8PerContextData);
-
- public:
- static std::unique_ptr<V8PerContextData> Create(v8::Local<v8::Context>);
-
- static V8PerContextData* From(v8::Local<v8::Context>);
-
- ~V8PerContextData();
-
- v8::Local<v8::Context> GetContext() { return context_.NewLocal(isolate_); }
-
- // To create JS Wrapper objects, we create a cache of a 'boiler plate'
- // object, and then simply Clone that object each time we need a new one.
- // This is faster than going through the full object creation process.
- v8::Local<v8::Object> CreateWrapperFromCache(const WrapperTypeInfo* type) {
- v8::Local<v8::Object> boilerplate = wrapper_boilerplates_.Get(type);
- return !boilerplate.IsEmpty() ? boilerplate->Clone()
- : CreateWrapperFromCacheSlowCase(type);
- }
-
- v8::Local<v8::Function> ConstructorForType(const WrapperTypeInfo* type) {
- v8::Local<v8::Function> interface_object = constructor_map_.Get(type);
- return (!interface_object.IsEmpty()) ? interface_object
- : ConstructorForTypeSlowCase(type);
- }
-
- v8::Local<v8::Object> PrototypeForType(const WrapperTypeInfo*);
-
- // Gets the constructor and prototype for a type, if they have already been
- // created. Returns true if they exist, and sets the existing values in
- // |prototypeObject| and |interfaceObject|. Otherwise, returns false, and the
- // values are set to empty objects (non-null).
- bool GetExistingConstructorAndPrototypeForType(
- const WrapperTypeInfo*,
- v8::Local<v8::Object>* prototype_object,
- v8::Local<v8::Function>* interface_object);
-
- void AddCustomElementBinding(std::unique_ptr<V0CustomElementBinding>);
-
- V8DOMActivityLogger* ActivityLogger() const { return activity_logger_; }
- void SetActivityLogger(V8DOMActivityLogger* activity_logger) {
- activity_logger_ = activity_logger;
- }
-
- // Garbage collected classes that use V8PerContextData to hold an instance
- // should subclass Data, and use addData / clearData / getData to manage the
- // instance.
- class CORE_EXPORT Data : public GarbageCollectedMixin {};
-
- void AddData(const char* key, Data*);
- void ClearData(const char* key);
- Data* GetData(const char* key);
-
- private:
- V8PerContextData(v8::Local<v8::Context>);
-
- v8::Local<v8::Object> CreateWrapperFromCacheSlowCase(const WrapperTypeInfo*);
- v8::Local<v8::Function> ConstructorForTypeSlowCase(const WrapperTypeInfo*);
-
- v8::Isolate* isolate_;
-
- // For each possible type of wrapper, we keep a boilerplate object.
- // The boilerplate is used to create additional wrappers of the same type.
- typedef V8GlobalValueMap<const WrapperTypeInfo*, v8::Object, v8::kNotWeak>
- WrapperBoilerplateMap;
- WrapperBoilerplateMap wrapper_boilerplates_;
-
- typedef V8GlobalValueMap<const WrapperTypeInfo*, v8::Function, v8::kNotWeak>
- ConstructorMap;
- ConstructorMap constructor_map_;
-
- std::unique_ptr<gin::ContextHolder> context_holder_;
-
- ScopedPersistent<v8::Context> context_;
- ScopedPersistent<v8::Value> error_prototype_;
-
- typedef Vector<std::unique_ptr<V0CustomElementBinding>>
- V0CustomElementBindingList;
- V0CustomElementBindingList custom_element_bindings_;
-
- // This is owned by a static hash map in V8DOMActivityLogger.
- V8DOMActivityLogger* activity_logger_;
-
- using DataMap = PersistentHeapHashMap<const char*, Member<Data>>;
- DataMap data_map_;
-};
-
-} // namespace blink
-
-#endif // V8PerContextData_h
+// This file has been moved to platform/bindings/V8PerContextData.h.
+// TODO(adithyas): Remove this file.
+#include "platform/bindings/V8PerContextData.h"

Powered by Google App Engine
This is Rietveld 408576698