Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/Source/platform/bindings/V8PerContextData.h

Issue 2843603002: Move ScriptWrappable and dependencies to platform/bindings (Closed)
Patch Set: Rebase and try again Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/bindings/V8PerContextData.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h b/third_party/WebKit/Source/platform/bindings/V8PerContextData.h
similarity index 90%
copy from third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
copy to third_party/WebKit/Source/platform/bindings/V8PerContextData.h
index 8c3a550b3c16f45c893241f5ab777ceb6402295a..b3bf2a737dc63c24d25e4d02826294997edc23d0 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
+++ b/third_party/WebKit/Source/platform/bindings/V8PerContextData.h
@@ -33,13 +33,13 @@
#include <memory>
-#include "bindings/core/v8/ScopedPersistent.h"
-#include "bindings/core/v8/V0CustomElementBinding.h"
-#include "bindings/core/v8/V8GlobalValueMap.h"
-#include "bindings/core/v8/WrapperTypeInfo.h"
-#include "core/CoreExport.h"
#include "gin/public/context_holder.h"
#include "gin/public/gin_embedders.h"
+#include "platform/PlatformExport.h"
+#include "platform/bindings/ScopedPersistent.h"
+#include "platform/bindings/V0CustomElementBinding.h"
+#include "platform/bindings/V8GlobalValueMap.h"
+#include "platform/bindings/WrapperTypeInfo.h"
#include "platform/wtf/Allocator.h"
#include "platform/wtf/HashMap.h"
#include "platform/wtf/Vector.h"
@@ -53,11 +53,12 @@ class V8DOMActivityLogger;
class V8PerContextData;
enum V8ContextEmbedderDataField {
- kV8ContextPerContextDataIndex =
- static_cast<int>(gin::kPerContextDataStartIndex + gin::kEmbedderBlink),
+ kV8ContextPerContextDataIndex = static_cast<int>(
+ gin::kPerContextDataStartIndex + // NOLINT(readability/enum_casing)
+ gin::kEmbedderBlink), // NOLINT(readability/enum_casing)
};
-class CORE_EXPORT V8PerContextData final {
+class PLATFORM_EXPORT V8PerContextData final {
USING_FAST_MALLOC(V8PerContextData);
WTF_MAKE_NONCOPYABLE(V8PerContextData);
@@ -106,7 +107,7 @@ class CORE_EXPORT V8PerContextData final {
// Garbage collected classes that use V8PerContextData to hold an instance
// should subclass Data, and use addData / clearData / getData to manage the
// instance.
- class CORE_EXPORT Data : public GarbageCollectedMixin {};
+ class PLATFORM_EXPORT Data : public GarbageCollectedMixin {};
void AddData(const char* key, Data*);
void ClearData(const char* key);

Powered by Google App Engine
This is Rietveld 408576698