Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h

Issue 2843603002: Move ScriptWrappable and dependencies to platform/bindings (Closed)
Patch Set: Rebase and try again Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h
index 86cc47d5db4034a2cc418e8c5bb26a62cd474f20..83c021132c63e55e8af28a60f0012dd20d96aeba 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h
@@ -2,57 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef ScriptWrappableVisitorVerifier_h
-#define ScriptWrappableVisitorVerifier_h
-
-#include "bindings/core/v8/ScriptWrappableVisitor.h"
-
-namespace blink {
-
-class ScriptWrappableVisitorVerifier : public WrapperVisitor {
- public:
- void DispatchTraceWrappers(const TraceWrapperBase* t) const override {
- t->TraceWrappers(this);
- }
-
- void TraceWrappers(const TraceWrapperV8Reference<v8::Value>&) const override {
- }
- void MarkWrapper(const v8::PersistentBase<v8::Value>*) const override {}
-
- bool PushToMarkingDeque(
- void (*trace_wrappers_callback)(const WrapperVisitor*, const void*),
- HeapObjectHeader* (*heap_object_header_callback)(const void*),
- void (*missed_write_barrier_callback)(void),
- const void* object) const override {
- if (!heap_object_header_callback(object)->IsWrapperHeaderMarked()) {
- // If this branch is hit, it means that a white (not discovered by
- // traceWrappers) object was assigned as a member to a black object
- // (already processed by traceWrappers). Black object will not be
- // processed anymore so White object will remain undetected and
- // therefore its wrapper and all wrappers reachable from it would be
- // collected.
-
- // This means there is a write barrier missing somewhere. Check the
- // backtrace to see which types are causing this and review all the
- // places where white object is set to a black object.
- missed_write_barrier_callback();
- NOTREACHED();
- }
- trace_wrappers_callback(this, object);
- return true;
- }
-
- bool MarkWrapperHeader(HeapObjectHeader* header) const override {
- if (!visited_headers_.Contains(header)) {
- visited_headers_.insert(header);
- return true;
- }
- return false;
- }
- void MarkWrappersInAllWorlds(const ScriptWrappable*) const override {}
-
- private:
- mutable WTF::HashSet<HeapObjectHeader*> visited_headers_;
-};
-}
-#endif
+// This file has been moved to
+// platform/bindings/ScriptWrappableVisitorVerifier.h.
+// TODO(adithyas): Remove this file.
+#include "platform/bindings/ScriptWrappableVisitorVerifier.h"

Powered by Google App Engine
This is Rietveld 408576698