Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: third_party/WebKit/Source/platform/bindings/V8PrivateProperty.h

Issue 2843603002: Move ScriptWrappable and dependencies to platform/bindings (Closed)
Patch Set: Rebase and try again Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/bindings/V8PrivateProperty.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h b/third_party/WebKit/Source/platform/bindings/V8PrivateProperty.h
similarity index 97%
copy from third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
copy to third_party/WebKit/Source/platform/bindings/V8PrivateProperty.h
index 7a6f8cb958ca55122fec61da3d267f9334ed4fac..05f2f6fc41c62e6c47d1620364f7ee07b93da06c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
+++ b/third_party/WebKit/Source/platform/bindings/V8PrivateProperty.h
@@ -7,10 +7,10 @@
#include <memory>
-#include "bindings/core/v8/ScriptPromiseProperties.h"
-#include "bindings/core/v8/V8BindingMacros.h"
-#include "bindings/core/v8/V8PerIsolateData.h"
-#include "core/CoreExport.h"
+#include "platform/PlatformExport.h"
+#include "platform/bindings/ScriptPromiseProperties.h"
+#include "platform/bindings/V8BindingMacros.h"
+#include "platform/bindings/V8PerIsolateData.h"
#include "platform/wtf/Allocator.h"
#include "platform/wtf/PtrUtil.h"
#include "v8/include/v8.h"
@@ -88,7 +88,7 @@ class ScriptWrappable;
// const char symbolName[] = "Interface#PrivateKeyName";
// auto private = V8PrivateProperty::createSymbol(isolate, symbolName);
// ...
-class CORE_EXPORT V8PrivateProperty {
+class PLATFORM_EXPORT V8PrivateProperty {
USING_FAST_MALLOC(V8PrivateProperty);
WTF_MAKE_NONCOPYABLE(V8PrivateProperty);
@@ -98,7 +98,7 @@ class CORE_EXPORT V8PrivateProperty {
// Retrieving/creating a global private symbol from a string is very
// expensive compared to get or set a private property. This class
// provides a way to cache a private symbol and re-use it.
- class CORE_EXPORT Symbol {
+ class PLATFORM_EXPORT Symbol {
STACK_ALLOCATED();
public:

Powered by Google App Engine
This is Rietveld 408576698