Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args. (Closed)

Created:
3 years, 8 months ago by yoichio
Modified:
3 years, 8 months ago
Reviewers:
kojii, yosin_UTC9
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change SelectionStartEnd() returning values instead of assigning into ref args. LayoutSelection::SelectionStartEnd(int& start_pos, int& end_pos); => std::pair<int, int> LayoutSelection::SelectionStartEnd(); TEST=No change in behavior. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2833343002 Cr-Commit-Position: refs/heads/master@{#466933} Committed: https://chromium.googlesource.com/chromium/src/+/9e8f21af25c5425136583d7658850e4a7db2146e

Patch Set 1 : rebase #

Messages

Total messages: 20 (15 generated)
yoichio
3 years, 8 months ago (2017-04-25 04:07:31 UTC) #13
yosin_UTC9
lgtm Nice!
3 years, 8 months ago (2017-04-25 07:05:37 UTC) #14
kojii
lgtm
3 years, 8 months ago (2017-04-25 08:51:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833343002/20001
3 years, 8 months ago (2017-04-25 09:11:40 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 09:15:36 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9e8f21af25c5425136583d765885...

Powered by Google App Engine
This is Rietveld 408576698