Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: third_party/WebKit/Source/core/editing/LayoutSelection.h

Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 kPaintInvalidationNewXOROld, 48 kPaintInvalidationNewXOROld,
49 kPaintInvalidationNewMinusOld 49 kPaintInvalidationNewMinusOld
50 }; 50 };
51 void SetSelection( 51 void SetSelection(
52 LayoutObject* start, 52 LayoutObject* start,
53 int start_pos, 53 int start_pos,
54 LayoutObject*, 54 LayoutObject*,
55 int end_pos, 55 int end_pos,
56 SelectionPaintInvalidationMode = kPaintInvalidationNewXOROld); 56 SelectionPaintInvalidationMode = kPaintInvalidationNewXOROld);
57 void ClearSelection(); 57 void ClearSelection();
58 void SelectionStartEnd(int& start_pos, int& end_pos); 58 std::pair<int, int> SelectionStartEnd();
59 void OnDocumentShutdown(); 59 void OnDocumentShutdown();
60 60
61 DECLARE_TRACE(); 61 DECLARE_TRACE();
62 62
63 private: 63 private:
64 LayoutSelection(FrameSelection&); 64 LayoutSelection(FrameSelection&);
65 65
66 const VisibleSelection& GetVisibleSelection() const; 66 const VisibleSelection& GetVisibleSelection() const;
67 67
68 SelectionInFlatTree CalcVisibleSelection( 68 SelectionInFlatTree CalcVisibleSelection(
(...skipping 19 matching lines...) Expand all
88 // TODO(yosin): Clarify the meaning of these variables. editing/ passes 88 // TODO(yosin): Clarify the meaning of these variables. editing/ passes
89 // them as offsets in the DOM tree but layout uses them as offset in the 89 // them as offsets in the DOM tree but layout uses them as offset in the
90 // layout tree. 90 // layout tree.
91 int selection_start_pos_; 91 int selection_start_pos_;
92 int selection_end_pos_; 92 int selection_end_pos_;
93 }; 93 };
94 94
95 } // namespace blink 95 } // namespace blink
96 96
97 #endif 97 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | third_party/WebKit/Source/core/editing/LayoutSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698