Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutText.cpp

Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutText.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutText.cpp b/third_party/WebKit/Source/core/layout/LayoutText.cpp
index 497a705aced9258dd8cb01c42b35ef0116eb88f7..6ec6ab729ad3b829e9971315c4d6a621e136f2d8 100644
--- a/third_party/WebKit/Source/core/layout/LayoutText.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutText.cpp
@@ -1559,7 +1559,7 @@ void LayoutText::SetSelectionState(SelectionState state) {
if (state == SelectionStart || state == SelectionEnd ||
state == SelectionBoth) {
int start_pos, end_pos;
- SelectionStartEnd(start_pos, end_pos);
+ std::tie(start_pos, end_pos) = SelectionStartEnd();
if (GetSelectionState() == SelectionStart) {
end_pos = TextLength();
@@ -2025,7 +2025,7 @@ LayoutRect LayoutText::LocalSelectionRect() const {
start_pos = 0;
end_pos = TextLength();
} else {
- SelectionStartEnd(start_pos, end_pos);
+ std::tie(start_pos, end_pos) = SelectionStartEnd();
if (GetSelectionState() == SelectionStart)
end_pos = TextLength();
else if (GetSelectionState() == SelectionEnd)
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/api/LineLayoutText.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698