Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 void UpdateAppearance(LayoutSelection::PaintHint); 246 void UpdateAppearance(LayoutSelection::PaintHint);
247 bool ShouldShowBlockCursor() const; 247 bool ShouldShowBlockCursor() const;
248 void SetShouldShowBlockCursor(bool); 248 void SetShouldShowBlockCursor(bool);
249 249
250 void CacheRangeOfDocument(Range*); 250 void CacheRangeOfDocument(Range*);
251 Range* DocumentCachedRange() const; 251 Range* DocumentCachedRange() const;
252 void ClearDocumentCachedRange(); 252 void ClearDocumentCachedRange();
253 253
254 FrameCaret& FrameCaretForTesting() const { return *frame_caret_; } 254 FrameCaret& FrameCaretForTesting() const { return *frame_caret_; }
255 255
256 void LayoutSelectionStartEnd(int& start_pos, int& end_pos); 256 std::pair<int, int> LayoutSelectionStartEnd();
257 void ClearLayoutSelection(); 257 void ClearLayoutSelection();
258 258
259 DECLARE_TRACE(); 259 DECLARE_TRACE();
260 260
261 private: 261 private:
262 friend class CaretDisplayItemClientTest; 262 friend class CaretDisplayItemClientTest;
263 friend class FrameSelectionTest; 263 friend class FrameSelectionTest;
264 friend class PaintControllerPaintTestForSlimmingPaintV1AndV2; 264 friend class PaintControllerPaintTestForSlimmingPaintV1AndV2;
265 friend class SelectionControllerTest; 265 friend class SelectionControllerTest;
266 FRIEND_TEST_ALL_PREFIXES(PaintControllerPaintTestForSlimmingPaintV1AndV2, 266 FRIEND_TEST_ALL_PREFIXES(PaintControllerPaintTestForSlimmingPaintV1AndV2,
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 314
315 } // namespace blink 315 } // namespace blink
316 316
317 #ifndef NDEBUG 317 #ifndef NDEBUG
318 // Outside the WebCore namespace for ease of invocation from gdb. 318 // Outside the WebCore namespace for ease of invocation from gdb.
319 void showTree(const blink::FrameSelection&); 319 void showTree(const blink::FrameSelection&);
320 void showTree(const blink::FrameSelection*); 320 void showTree(const blink::FrameSelection*);
321 #endif 321 #endif
322 322
323 #endif // FrameSelection_h 323 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698