third_party/WebKit/Source/core/editing/LayoutSelection.h - Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/LayoutSelection.h

Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/LayoutSelection.h

diff --git a/third_party/WebKit/Source/core/editing/LayoutSelection.h b/third_party/WebKit/Source/core/editing/LayoutSelection.h

index ac5b3c0f850950bb54c637deb4ae0a4dd71d3d52..b49f079a950aabb0b1e108ad526ad9326aa35f7f 100644

--- a/third_party/WebKit/Source/core/editing/LayoutSelection.h

+++ b/third_party/WebKit/Source/core/editing/LayoutSelection.h

@@ -55,7 +55,7 @@ class LayoutSelection final : public GarbageCollected<LayoutSelection> {

int end_pos,

SelectionPaintInvalidationMode = kPaintInvalidationNewXOROld);

void ClearSelection();

- void SelectionStartEnd(int& start_pos, int& end_pos);

+ std::pair<int, int> SelectionStartEnd();

void OnDocumentShutdown();

DECLARE_TRACE();