third_party/WebKit/Source/core/layout/LayoutObject.h - Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h

index 683424a848048440e1f52be02f05b514a753378a..87dd906004d02246c8c198662d568ae9cb36be74 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h

@@ -1544,7 +1544,7 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,

// to get notified of any image change.

virtual void ImageChanged(WrappedImagePtr, const IntRect* = nullptr) {}

- void SelectionStartEnd(int& spos, int& epos) const;

+ std::pair<int, int> SelectionStartEnd() const;

void Remove() {

if (Parent())