third_party/WebKit/Source/core/editing/FrameSelection.cpp - Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

index cd529ad899a1cdf79ec9ede0af93f9715a900b41..9493c9fce540591bb20f65d672e842e65bb96cc3 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

@@ -1164,8 +1164,8 @@ void FrameSelection::ClearDocumentCachedRange() {

selection_editor_->ClearDocumentCachedRange();

}

-void FrameSelection::LayoutSelectionStartEnd(int& start_pos, int& end_pos) {

- layout_selection_->SelectionStartEnd(start_pos, end_pos);

+std::pair<int, int> FrameSelection::LayoutSelectionStartEnd() {

+ return layout_selection_->SelectionStartEnd();

}

void FrameSelection::ClearLayoutSelection() {