Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2833343002: Change SelectionStartEnd() returning values instead of assigning into ref args. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1526 matching lines...) Expand 10 before | Expand all | Expand 10 after
1537 1537
1538 // ImageResourceClient override. 1538 // ImageResourceClient override.
1539 void ImageChanged(ImageResourceContent*, const IntRect* = nullptr) final; 1539 void ImageChanged(ImageResourceContent*, const IntRect* = nullptr) final;
1540 bool WillRenderImage() final; 1540 bool WillRenderImage() final;
1541 bool GetImageAnimationPolicy(ImageAnimationPolicy&) final; 1541 bool GetImageAnimationPolicy(ImageAnimationPolicy&) final;
1542 1542
1543 // Sub-classes that have an associated image need to override this function 1543 // Sub-classes that have an associated image need to override this function
1544 // to get notified of any image change. 1544 // to get notified of any image change.
1545 virtual void ImageChanged(WrappedImagePtr, const IntRect* = nullptr) {} 1545 virtual void ImageChanged(WrappedImagePtr, const IntRect* = nullptr) {}
1546 1546
1547 void SelectionStartEnd(int& spos, int& epos) const; 1547 std::pair<int, int> SelectionStartEnd() const;
1548 1548
1549 void Remove() { 1549 void Remove() {
1550 if (Parent()) 1550 if (Parent())
1551 Parent()->RemoveChild(this); 1551 Parent()->RemoveChild(this);
1552 } 1552 }
1553 1553
1554 bool VisibleToHitTestRequest(const HitTestRequest& request) const { 1554 bool VisibleToHitTestRequest(const HitTestRequest& request) const {
1555 return Style()->Visibility() == EVisibility::kVisible && 1555 return Style()->Visibility() == EVisibility::kVisible &&
1556 (request.IgnorePointerEventsNone() || 1556 (request.IgnorePointerEventsNone() ||
1557 Style()->PointerEvents() != EPointerEvents::kNone) && 1557 Style()->PointerEvents() != EPointerEvents::kNone) &&
(...skipping 1265 matching lines...) Expand 10 before | Expand all | Expand 10 after
2823 CORE_EXPORT void showLineTree(const blink::LayoutObject*); 2823 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
2824 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1); 2824 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
2825 // We don't make object2 an optional parameter so that showLayoutTree 2825 // We don't make object2 an optional parameter so that showLayoutTree
2826 // can be called from gdb easily. 2826 // can be called from gdb easily.
2827 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1, 2827 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
2828 const blink::LayoutObject* object2); 2828 const blink::LayoutObject* object2);
2829 2829
2830 #endif 2830 #endif
2831 2831
2832 #endif // LayoutObject_h 2832 #endif // LayoutObject_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/LayoutSelection.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698