[DevTools] Consolidate overlay-related functionality in Overlay domain

[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#465422}
Committed: https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae58cff1c787bec
Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Original-Commit-Position: refs/heads/master@{#465812}
Committed: https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a689648621fa29f14
Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#466489}
Committed: https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4122f4d50246a
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#466826}
Committed: https://chromium.googlesource.com/chromium/src/+/3b36efad6b17e10ae243a8668528aae310a312da

[dgozman, 2017-04-17 21:40:12]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 21:40:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 21:44:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 21:44:46]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dgozman, 2017-04-17 23:21:26]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 23:21:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-04-18 00:03:10]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2017-04-18 00:03:11]

Could you please take a look?

[pfeldman, 2017-04-18 00:25:08]

lgtm

Please test show size on resize, screencast highlighter override.

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h (right):

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h:220:
protocol::Response NodeForRemoteId(const String& id, Node*&);
NodeForRemoteObjectId

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/protocol_compatibility_errors.json
(right):

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/protocol_compatibility_errors.json:3:
"DOM.highlightRect: command has been removed",
redirect 'em!

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js
(right):

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js:136: if
(this._showPaintRects)
Follow up with transient setting?

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/OverlayModel.js (right):

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/OverlayModel.js:78:
setShowPaintRects(show) {
Annotate!

[commit-bot: I haz the power, 2017-04-18 01:30:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 01:30:23]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-18 20:39:32]

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h (right):

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h:220:
protocol::Response NodeForRemoteId(const String& id, Node*&);
On 2017/04/18 00:25:08, pfeldman wrote:
> NodeForRemoteObjectId

Done.

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/protocol_compatibility_errors.json
(right):

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/protocol_compatibility_errors.json:3:
"DOM.highlightRect: command has been removed",
On 2017/04/18 00:25:08, pfeldman wrote:
> redirect 'em!

Done.

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js
(right):

https://codereview.chromium.org/2819183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js:136: if
(this._showPaintRects)
On 2017/04/18 00:25:08, pfeldman wrote:
> Follow up with transient setting?

Done.

[dgozman, 2017-04-18 20:40:35]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 20:41:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-04-18 21:21:10]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 21:22:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-04-18 22:50:42]

The CQ bit was unchecked by dgozman@chromium.org

[dgozman, 2017-04-18 22:50:47]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-04-18 22:50:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2819183002/#ps80001
(title: "screencast fix")

[commit-bot: I haz the power, 2017-04-18 22:51:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 23:35:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492555847690060,
"parent_rev": "96154a7890bca4d76fad2c3eeb188ebf200b883c", "commit_rev":
"8982f602a8e1f521949d8dd8dae58cff1c787bec"}

[commit-bot: I haz the power, 2017-04-18 23:35:39]

Description was changed from

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
==========

to

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none

Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
==========

[commit-bot: I haz the power, 2017-04-18 23:35:42]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...

[ojan, 2017-04-18 23:54:25]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2826833002/ by ojan@chromium.org.

The reason for reverting is: Broke compile.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle...

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrom...
.

[findit-for-me, 2017-04-19 00:05:38]

Findit(https://goo.gl/kROfz5) confirmed this CL at revision 465422 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[dgozman, 2017-04-19 21:28:11]

Description was changed from

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none

Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
==========

to

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none

Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
==========

[dgozman, 2017-04-19 21:29:43]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 21:30:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-04-19 21:30:47]

dgozman@chromium.org changed reviewers:
+ skyostil@chromium.org

[dgozman, 2017-04-19 21:30:47]

TBR'ing skyostil@ for headless: we are removing rendering domain, which is
unlikely to be used by headless ever.

[dgozman, 2017-04-19 21:30:59]

Description was changed from

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none

Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
==========

to

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
==========

[commit-bot: I haz the power, 2017-04-19 23:32:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 23:32:58]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-19 23:36:00]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-04-19 23:36:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2819183002/#ps100001
(title: "headless compile")

[commit-bot: I haz the power, 2017-04-19 23:36:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 23:45:33]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1492644960761740,
"parent_rev": "85827883d6102e09951e13c14c8d383cd6e3833f", "commit_rev":
"7afbb9a64fbd30254a2dab9a689648621fa29f14"}

[commit-bot: I haz the power, 2017-04-19 23:45:51]

Description was changed from

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
==========

to

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#465812}
Committed:
https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a6896...
==========

[commit-bot: I haz the power, 2017-04-19 23:45:52]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a6896...

[aboxhall, 2017-04-20 01:32:24]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2827183003/ by aboxhall@chromium.org.

The reason for reverting is: This caused a lot of test failures in WebKit Linux
Trusty Leak:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu....

[dgozman, 2017-04-20 21:23:40]

Description was changed from

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#465812}
Committed:
https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a6896...
==========

to

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#465812}
Committed:
https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a6896...
==========

[dgozman, 2017-04-20 21:32:07]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 21:33:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 00:05:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 00:05:07]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-21 21:44:33]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-04-21 21:44:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2819183002/#ps120001
(title: "fixing leak")

[commit-bot: I haz the power, 2017-04-21 21:45:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:34:54]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492811073932530,
"parent_rev": "94191025bc29f325d91565c9520af6495f22be09", "commit_rev":
"c8abe8c3b07d77195777e07180a4122f4d50246a"}

[commit-bot: I haz the power, 2017-04-21 23:35:04]

Description was changed from

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#465812}
Committed:
https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a6896...
==========

to

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Original-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#465812}
Committed:
https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a6896...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#466489}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4...
==========

[commit-bot: I haz the power, 2017-04-21 23:35:07]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4...

[Dirk Pranke, 2017-04-23 04:32:40]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2835843002/ by dpranke@chromium.org.

The reason for reverting is: This seems to be breaking the devtools closure
compiler, i.e., closure is reporting an error:

https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/55326
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_T...

Command: /usr/bin/python ../../testing/scripts/run_devtools_check.py
../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py
--isolated-script-test-output=/b/s/w/ioH2ERuI/output.json
--isolated-script-test-chartjson-output=/b/s/w/ioH2ERuI/chartjson-output.json

Java executable: /usr/bin/java
Compiling frontend...
Compiling devtools_compatibility.js...
Verifying JSDoc comments...
devtools_compatibility.js compilation output:
0 error(s), 0 warning(s), 95.2% typed

devtools frontend compilation output:
/b/s/w/itFkGMoq/tmp_x1qK7/front_end/emulation/DeviceModeModel.js:640: WARNING -
Property renderingAgent never defined on SDK.Target
    this._target.renderingAgent().setShowViewportSizeOnResize(false);
                 ^^^^^^^^^^^^^^

0 error(s), 1 warning(s), 94.3% typed

ERRORS DETECTED
Running ['/usr/bin/python',
'../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py'] in None
(env: None)
Command ['/usr/bin/python',
'../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py'] returned
exit code 1.

[dgozman, 2017-04-24 17:43:39]

Description was changed from

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Original-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#465812}
Committed:
https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a6896...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#466489}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4...
==========

to

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Original-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#465812}
Committed:
https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a6896...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#466489}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4...
==========

[dgozman, 2017-04-24 17:43:48]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 17:44:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 18:51:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 18:51:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sami, 2017-04-24 18:58:38]

lgtm to remove.

[dgozman, 2017-04-24 21:37:29]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-04-24 21:37:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2819183002/#ps140001
(title: "rebased bad merge")

[commit-bot: I haz the power, 2017-04-24 21:38:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 23:47:27]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493069849287040,
"parent_rev": "432f5958c488cd4b6c1548efc9dedd33f82d5cc3", "commit_rev":
"3b36efad6b17e10ae243a8668528aae310a312da"}

[commit-bot: I haz the power, 2017-04-24 23:48:02]

Description was changed from

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Original-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#465812}
Committed:
https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a6896...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#466489}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4...
==========

to

==========
[DevTools] Consolidate overlay-related functionality in Overlay domain

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#465422}
Committed:
https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae5...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Original-Commit-Position: refs/heads/master@{#465812}
Committed:
https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a6896...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#466489}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4...
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#466826}
Committed:
https://chromium.googlesource.com/chromium/src/+/3b36efad6b17e10ae243a8668528...
==========

[commit-bot: I haz the power, 2017-04-24 23:48:04]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/3b36efad6b17e10ae243a8668528...