Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)
Patch Set: rebased bad merge Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
index 428dba6e34f0fefdac734d1683be889c1604841c..2e2a503fdbf466bfff7842f56f5207405c426db9 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
@@ -81,8 +81,6 @@ static const char kPageAgentScriptsToEvaluateOnLoad[] =
"pageAgentScriptsToEvaluateOnLoad";
static const char kScreencastEnabled[] = "screencastEnabled";
static const char kAutoAttachToCreatedPages[] = "autoAttachToCreatedPages";
-static const char kOverlaySuspended[] = "overlaySuspended";
-static const char kOverlayMessage[] = "overlayMessage";
}
namespace {
@@ -376,13 +374,6 @@ InspectorPageAgent::InspectorPageAgent(
void InspectorPageAgent::Restore() {
if (state_->booleanProperty(PageAgentState::kPageAgentEnabled, false))
enable();
- if (client_) {
- String overlay_message;
- state_->getString(PageAgentState::kOverlayMessage, &overlay_message);
- client_->ConfigureOverlay(
- state_->booleanProperty(PageAgentState::kOverlaySuspended, false),
- overlay_message);
- }
}
Response InspectorPageAgent::enable() {
@@ -403,7 +394,6 @@ Response InspectorPageAgent::disable() {
resource_content_loader_client_id_);
stopScreencast();
- configureOverlay(false, String());
FinishReload();
return Response::OK();
@@ -864,18 +854,6 @@ Response InspectorPageAgent::stopScreencast() {
return Response::OK();
}
-Response InspectorPageAgent::configureOverlay(Maybe<bool> suspended,
- Maybe<String> message) {
- state_->setBoolean(PageAgentState::kOverlaySuspended,
- suspended.fromMaybe(false));
- state_->setString(PageAgentState::kOverlaySuspended,
- message.fromMaybe(String()));
- if (client_)
- client_->ConfigureOverlay(suspended.fromMaybe(false),
- message.fromMaybe(String()));
- return Response::OK();
-}
-
Response InspectorPageAgent::getLayoutMetrics(
std::unique_ptr<protocol::Page::LayoutViewport>* out_layout_viewport,
std::unique_ptr<protocol::Page::VisualViewport>* out_visual_viewport,

Powered by Google App Engine
This is Rietveld 408576698