Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)
Patch Set: rebased bad merge Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index bb2303f4ca6cab3d1e0238eaba2761603389aef1..aa3ad81bead5e081ee8de7f79754f8550b24b3e5 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -162,7 +162,7 @@
#include "web/DedicatedWorkerMessagingProxyProviderImpl.h"
#include "web/DevToolsEmulator.h"
#include "web/FullscreenController.h"
-#include "web/InspectorOverlay.h"
+#include "web/InspectorOverlayAgent.h"
#include "web/LinkHighlightImpl.h"
#include "web/PageOverlay.h"
#include "web/PrerendererClientImpl.h"
@@ -432,9 +432,9 @@ WebDevToolsAgentImpl* WebViewImpl::MainFrameDevToolsAgentImpl() {
return main_frame ? main_frame->DevToolsAgentImpl() : nullptr;
}
-InspectorOverlay* WebViewImpl::GetInspectorOverlay() {
+InspectorOverlayAgent* WebViewImpl::GetInspectorOverlay() {
if (WebDevToolsAgentImpl* devtools = MainFrameDevToolsAgentImpl())
- return devtools->Overlay();
+ return devtools->OverlayAgent();
return nullptr;
}
@@ -2026,7 +2026,7 @@ void WebViewImpl::UpdateAllLifecyclePhases() {
PageWidgetDelegate::UpdateAllLifecyclePhases(*page_,
*MainFrameImpl()->GetFrame());
- if (InspectorOverlay* overlay = GetInspectorOverlay()) {
+ if (InspectorOverlayAgent* overlay = GetInspectorOverlay()) {
overlay->UpdateAllLifecyclePhases();
// TODO(chrishtr): integrate paint into the overlay's lifecycle.
if (overlay->GetPageOverlay() &&
@@ -2169,7 +2169,7 @@ WebInputEventResult WebViewImpl::HandleInputEvent(
if (dev_tools_emulator_->HandleInputEvent(input_event))
return WebInputEventResult::kHandledSuppressed;
- if (InspectorOverlay* overlay = GetInspectorOverlay()) {
+ if (InspectorOverlayAgent* overlay = GetInspectorOverlay()) {
if (overlay->HandleInputEvent(input_event))
return WebInputEventResult::kHandledSuppressed;
}
@@ -4132,7 +4132,7 @@ AnimationWorkletProxyClient* WebViewImpl::CreateAnimationWorkletProxyClient() {
void WebViewImpl::UpdatePageOverlays() {
if (page_color_overlay_)
page_color_overlay_->Update();
- if (InspectorOverlay* overlay = GetInspectorOverlay()) {
+ if (InspectorOverlayAgent* overlay = GetInspectorOverlay()) {
PageOverlay* inspector_page_overlay = overlay->GetPageOverlay();
if (inspector_page_overlay)
inspector_page_overlay->Update();
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698