third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js - Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)

Patch Set: rebased bad merge Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js

index f8d7034954215948f6872bc31cb8f9cac39e6ae9..7b7e45452a09ff458a62a9be1f0b6d1a8d437937 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js

@@ -15,8 +15,9 @@ Elements.ElementsTreeElementHighlighter = class {

this._treeOutline.addEventListener(UI.TreeOutline.Events.ElementCollapsed, this._clearState, this);

this._treeOutline.addEventListener(Elements.ElementsTreeOutline.Events.SelectedNodeChanged, this._clearState, this);

SDK.targetManager.addModelListener(

- SDK.DOMModel, SDK.DOMModel.Events.NodeHighlightedInOverlay, this._highlightNode, this);

- this._treeOutline.domModel().addEventListener(SDK.DOMModel.Events.InspectModeWillBeToggled, this._clearState, this);

+ SDK.OverlayModel, SDK.OverlayModel.Events.HighlightNodeRequested, this._highlightNode, this);

+ this._treeOutline.domModel().overlayModel().addEventListener(

+ SDK.OverlayModel.Events.InspectModeWillBeToggled, this._clearState, this);

}

/**