third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js - Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)

Patch Set: rebased bad merge Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/module.json ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

index 4862b79de29e4de7917ea4fa04df9366501bc34b..62a35a087fe2254121983be9cb650d6b771ac7d2 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

@@ -433,11 +433,11 @@ Sources.NavigatorView = class extends UI.VBox {

function hoverCallback(hovered) {

if (hovered) {

- var domModel = target.model(SDK.DOMModel);

- if (domModel)

- domModel.highlightFrame(frame.id);

+ var overlayModel = target.model(SDK.OverlayModel);

+ if (overlayModel)

+ overlayModel.highlightFrame(frame.id);

} else {

- SDK.DOMModel.hideDOMNodeHighlight();

+ SDK.OverlayModel.hideDOMNodeHighlight();

}

return frameNode;