Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/OverlayController.js

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)
Patch Set: rebased bad merge Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/main/OverlayController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js b/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js
deleted file mode 100644
index e6800cef0ad6b286bec3dfd691eff010347722f4..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js
+++ /dev/null
@@ -1,43 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-/**
- * @unrestricted
- */
-Main.OverlayController = class {
- constructor() {
- Common.moduleSetting('disablePausedStateOverlay').addChangeListener(this._updateAllOverlays, this);
- SDK.targetManager.addModelListener(
- SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerPaused, this._updateOverlay, this);
- SDK.targetManager.addModelListener(
- SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerResumed, this._updateOverlay, this);
- // TODO(dgozman): we should get DebuggerResumed on navigations instead of listening to GlobalObjectCleared.
- SDK.targetManager.addModelListener(
- SDK.DebuggerModel, SDK.DebuggerModel.Events.GlobalObjectCleared, this._updateOverlay, this);
- SDK.targetManager.addEventListener(SDK.TargetManager.Events.SuspendStateChanged, this._updateAllOverlays, this);
- }
-
- _updateAllOverlays() {
- for (var debuggerModel of SDK.targetManager.models(SDK.DebuggerModel))
- this._updateTargetOverlay(debuggerModel);
- }
-
- /**
- * @param {!Common.Event} event
- */
- _updateOverlay(event) {
- this._updateTargetOverlay(/** @type {!SDK.DebuggerModel} */ (event.data));
- }
-
- /**
- * @param {!SDK.DebuggerModel} debuggerModel
- */
- _updateTargetOverlay(debuggerModel) {
- if (!debuggerModel.target().hasBrowserCapability())
- return;
- var message = debuggerModel.isPaused() && !Common.moduleSetting('disablePausedStateOverlay').get() ?
- Common.UIString('Paused in debugger') :
- undefined;
- debuggerModel.target().pageAgent().configureOverlay(SDK.targetManager.allTargetsSuspended(), message);
- }
-};

Powered by Google App Engine
This is Rietveld 408576698