third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)

Patch Set: rebased bad merge Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

index b8c5d73471bae256993c1ddeabf050e6d87de987..a8b2810df358155ee8354743ff50d0302f20caa4 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -836,7 +836,7 @@ Elements.StylePropertiesSection = class {

_onMouseOutSelector() {

if (this._hoverTimer)

clearTimeout(this._hoverTimer);

- SDK.DOMModel.hideDOMNodeHighlight();

+ SDK.OverlayModel.hideDOMNodeHighlight();

}

_onMouseEnterSelector() {

@@ -846,11 +846,11 @@ Elements.StylePropertiesSection = class {

}

_highlight() {

- SDK.DOMModel.hideDOMNodeHighlight();

+ SDK.OverlayModel.hideDOMNodeHighlight();

var node = this._parentPane.node();

- var domModel = node.domModel();

var selectors = this._style.parentRule ? this._style.parentRule.selectorText() : undefined;

- domModel.highlightDOMNodeWithConfig(node.id, {mode: 'all', showInfo: undefined, selectors: selectors});

+ node.domModel().overlayModel().highlightDOMNodeWithConfig(

+ node.id, {mode: 'all', showInfo: undefined, selectors: selectors});

}

/**