third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js - Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)

Patch Set: rebased bad merge Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

index d9cba7026ce0076d0c8119ac73fb77b75aabd519..8e3a2b246a05300e3e2129012645cc54f846b314 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

@@ -124,7 +124,7 @@ Elements.MetricsSidebarPane = class extends Elements.ElementsSidebarPane {

this.node().highlight(mode);

} else {

delete this._highlightMode;

- SDK.DOMModel.hideDOMNodeHighlight();

+ SDK.OverlayModel.hideDOMNodeHighlight();

}

for (var i = 0; this._boxElements && i < this._boxElements.length; ++i) {