Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility (Closed)

Created:
3 years, 8 months ago by pilgrim_google
Modified:
3 years, 8 months ago
Reviewers:
tkent, haraken
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, je_julie, jsbell, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT with DCHECK in modules/accessibility BUG=707651 Review-Url: https://codereview.chromium.org/2804383002 Cr-Commit-Position: refs/heads/master@{#463037} Committed: https://chromium.googlesource.com/chromium/src/+/6648272c4139109fa7a452b6f4da3e124d9d02a8

Patch Set 1 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -62 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp View 2 chunks +2 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 15 chunks +18 lines, -18 lines 5 comments Download
M third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp View 3 chunks +4 lines, -4 lines 2 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 10 chunks +11 lines, -11 lines 1 comment Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSlider.cpp View 2 chunks +3 lines, -3 lines 1 comment Download
M third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
pilgrim_google
3 years, 8 months ago (2017-04-07 20:36:46 UTC) #3
haraken
LGTM
3 years, 8 months ago (2017-04-07 22:31:44 UTC) #7
haraken
You won't need to create a new bug for each CL. You can use issue ...
3 years, 8 months ago (2017-04-07 22:33:10 UTC) #8
pilgrim_google
On 2017/04/07 at 22:33:10, haraken wrote: > You won't need to create a new bug ...
3 years, 8 months ago (2017-04-07 22:59:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804383002/1
3 years, 8 months ago (2017-04-07 23:00:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6648272c4139109fa7a452b6f4da3e124d9d02a8
3 years, 8 months ago (2017-04-07 23:11:21 UTC) #14
tkent
3 years, 8 months ago (2017-04-09 23:21:23 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
(right):

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp:103:
DCHECK(widths.size() == len);
Use DCHECK_EQ

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp (right):

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp:1782:
DCHECK(anchorOffset >= 0);
Use DCHECK_GE

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp:1784:
DCHECK(focusOffset >= 0);
Use DCHECK_GE

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp:1820:
DCHECK(start >= 0);
Use DCHECK_GE

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp:1822:
DCHECK(end >= 0);
Use DCHECK_GE

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp:2462:
DCHECK(areaObject->axObjectID() != 0);
Use DCHECK_NE

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp (right):

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp:70:
DCHECK(m_children.size() == 1);
Use DCHECK_EQ

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp:126:
DCHECK(childObjects.size() == 1);
use DCHECK_EQ

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:2257:
DCHECK(child->parentObject() == this);
Use DCHECK_EQ

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXSlider.cpp (right):

https://codereview.chromium.org/2804383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXSlider.cpp:104:
DCHECK(m_children.size() == 1);
Use DCHECK_EQ

Powered by Google App Engine
This is Rietveld 408576698