Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXTable.cpp

Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 m_rows.clear(); 357 m_rows.clear();
358 m_columns.clear(); 358 m_columns.clear();
359 359
360 if (m_headerContainer) { 360 if (m_headerContainer) {
361 m_headerContainer->detachFromParent(); 361 m_headerContainer->detachFromParent();
362 m_headerContainer = nullptr; 362 m_headerContainer = nullptr;
363 } 363 }
364 } 364 }
365 365
366 void AXTable::addChildren() { 366 void AXTable::addChildren() {
367 ASSERT(!isDetached()); 367 DCHECK(!isDetached());
368 if (!isAXTable()) { 368 if (!isAXTable()) {
369 AXLayoutObject::addChildren(); 369 AXLayoutObject::addChildren();
370 return; 370 return;
371 } 371 }
372 372
373 ASSERT(!m_haveChildren); 373 DCHECK(!m_haveChildren);
374 374
375 m_haveChildren = true; 375 m_haveChildren = true;
376 if (!m_layoutObject || !m_layoutObject->isTable()) 376 if (!m_layoutObject || !m_layoutObject->isTable())
377 return; 377 return;
378 378
379 LayoutTable* table = toLayoutTable(m_layoutObject); 379 LayoutTable* table = toLayoutTable(m_layoutObject);
380 AXObjectCacheImpl& axCache = axObjectCache(); 380 AXObjectCacheImpl& axCache = axObjectCache();
381 381
382 Node* tableNode = table->node(); 382 Node* tableNode = table->node();
383 if (!isHTMLTableElement(tableNode)) 383 if (!isHTMLTableElement(tableNode))
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 } 606 }
607 607
608 DEFINE_TRACE(AXTable) { 608 DEFINE_TRACE(AXTable) {
609 visitor->trace(m_rows); 609 visitor->trace(m_rows);
610 visitor->trace(m_columns); 610 visitor->trace(m_columns);
611 visitor->trace(m_headerContainer); 611 visitor->trace(m_headerContainer);
612 AXLayoutObject::trace(visitor); 612 AXLayoutObject::trace(visitor);
613 } 613 }
614 614
615 } // namespace blink 615 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698