Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp

Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 if (!m_parent->accessibilityIsIgnored()) 114 if (!m_parent->accessibilityIsIgnored())
115 return false; 115 return false;
116 116
117 if (ignoredReasons) 117 if (ignoredReasons)
118 m_parent->computeAccessibilityIsIgnored(ignoredReasons); 118 m_parent->computeAccessibilityIsIgnored(ignoredReasons);
119 119
120 return true; 120 return true;
121 } 121 }
122 122
123 void AXTableColumn::addChildren() { 123 void AXTableColumn::addChildren() {
124 ASSERT(!isDetached()); 124 DCHECK(!isDetached());
125 ASSERT(!m_haveChildren); 125 DCHECK(!m_haveChildren);
126 126
127 m_haveChildren = true; 127 m_haveChildren = true;
128 if (!m_parent || !m_parent->isAXTable()) 128 if (!m_parent || !m_parent->isAXTable())
129 return; 129 return;
130 130
131 AXTable* parentTable = toAXTable(m_parent); 131 AXTable* parentTable = toAXTable(m_parent);
132 int numRows = parentTable->rowCount(); 132 int numRows = parentTable->rowCount();
133 133
134 for (int i = 0; i < numRows; i++) { 134 for (int i = 0; i < numRows; i++) {
135 AXTableCell* cell = parentTable->cellForColumnAndRow(m_columnIndex, i); 135 AXTableCell* cell = parentTable->cellForColumnAndRow(m_columnIndex, i);
136 if (!cell) 136 if (!cell)
137 continue; 137 continue;
138 138
139 // make sure the last one isn't the same as this one (rowspan cells) 139 // make sure the last one isn't the same as this one (rowspan cells)
140 if (m_children.size() > 0 && m_children.back() == cell) 140 if (m_children.size() > 0 && m_children.back() == cell)
141 continue; 141 continue;
142 142
143 m_children.push_back(cell); 143 m_children.push_back(cell);
144 } 144 }
145 } 145 }
146 146
147 } // namespace blink 147 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698