third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp - Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('K') | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp b/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

index c4ba92f543cc10e21aa2d00a7da7f842fe57c457..35c9f487d03e26d7f76ef3fd04ddf9d6aa748521 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

@@ -138,7 +138,7 @@ String AXListBoxOption::textAlternative(bool recursive,

// If nameSources is non-null, relatedObjects is used in filling it in, so it

// must be non-null as well.

if (nameSources)

- ASSERT(relatedObjects);

+ DCHECK(relatedObjects);

if (!getNode())

return String();