third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp - Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

index e64c72263ca98fd3e7f0c472fc37f57be1cb9b2d..dabd8ef269519c9a262fa96b0a97439b970c2096 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

@@ -100,7 +100,7 @@ void AXInlineTextBox::textCharacterOffsets(Vector<int>& offsets) const {

unsigned len = m_inlineTextBox->len();

Vector<float> widths;

m_inlineTextBox->characterWidths(widths);

- ASSERT(widths.size() == len);

+ DCHECK(widths.size() == len);

tkent 2017/04/09 23:21:22 Use DCHECK_EQ

offsets.resize(len);

float widthSoFar = 0;

@@ -132,7 +132,7 @@ String AXInlineTextBox::name(AXNameFrom& nameFrom,

}

AXObject* AXInlineTextBox::computeParent() const {

- ASSERT(!isDetached());

+ DCHECK(!isDetached());

if (!m_inlineTextBox || !m_axObjectCache)

return 0;