third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp - Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp

Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp ('K') | « third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp b/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp

index 7530e9516130584dd02481557aa85cce4c80dda5..b54df405e47fc905dc6cb1867f551725e0e0a4b4 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp

@@ -61,7 +61,7 @@ bool AXMenuListPopup::computeAccessibilityIsIgnored(

AXMenuListOption* AXMenuListPopup::menuListOptionAXObject(

HTMLElement* element) const {

- ASSERT(element);

+ DCHECK(element);

if (!isHTMLOptionElement(*element))

return 0;

@@ -93,7 +93,7 @@ bool AXMenuListPopup::press() {

}

void AXMenuListPopup::addChildren() {

- ASSERT(!isDetached());

+ DCHECK(!isDetached());

if (!m_parent)

return;