Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp

Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp b/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
index 91dd98e25ba7e0b69a090550c76328590c4ec37c..703045339c573c31cb6bb94645861d731ce0c401 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
@@ -67,7 +67,7 @@ void AXMenuList::clearChildren() {
// There's no reason to clear our AXMenuListPopup child. If we get a
// call to clearChildren, it's because the options might have changed,
// so call it on our popup.
- ASSERT(m_children.size() == 1);
+ DCHECK(m_children.size() == 1);
tkent 2017/04/09 23:21:23 Use DCHECK_EQ
m_children[0]->clearChildren();
m_childrenDirty = false;
}
@@ -77,7 +77,7 @@ bool AXMenuList::nameFromContents() const {
}
void AXMenuList::addChildren() {
- ASSERT(!isDetached());
+ DCHECK(!isDetached());
m_haveChildren = true;
AXObjectCacheImpl& cache = axObjectCache();
@@ -123,8 +123,8 @@ bool AXMenuList::canSetFocusAttribute() const {
void AXMenuList::didUpdateActiveOption(int optionIndex) {
const auto& childObjects = children();
if (!childObjects.isEmpty()) {
- ASSERT(childObjects.size() == 1);
- ASSERT(childObjects[0]->isMenuListPopup());
+ DCHECK(childObjects.size() == 1);
tkent 2017/04/09 23:21:23 use DCHECK_EQ
+ DCHECK(childObjects[0]->isMenuListPopup());
if (childObjects[0]->isMenuListPopup()) {
if (AXMenuListPopup* popup = toAXMenuListPopup(childObjects[0].get()))

Powered by Google App Engine
This is Rietveld 408576698